From owner-cvs-src@FreeBSD.ORG  Sun Mar  7 19:14:27 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id AA1AF16A4CE; Sun,  7 Mar 2004 19:14:27 -0800 (PST)
Received: from cs.rice.edu (cs.rice.edu [128.42.1.30])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 94ABC43D2F; Sun,  7 Mar 2004 19:14:27 -0800 (PST)
	(envelope-from alc@cs.rice.edu)
Received: from localhost (calypso.cs.rice.edu [128.42.1.127])
	by cs.rice.edu (Postfix) with ESMTP
	id 1D1C34AAB7; Sun,  7 Mar 2004 21:14:27 -0600 (CST)
Received: from cs.rice.edu ([128.42.1.30])
 by localhost (calypso.cs.rice.edu [128.42.1.127]) (amavisd-new, port 10024)
 with LMTP id 05021-01-16; Sun,  7 Mar 2004 21:14:26 -0600 (CST)
Received: by cs.rice.edu (Postfix, from userid 19572)
	id A521B4AAB2; Sun,  7 Mar 2004 21:14:26 -0600 (CST)
Date: Sun, 7 Mar 2004 21:14:26 -0600
From: Alan Cox <alc@cs.rice.edu>
To: Peter Wemm <peter@wemm.org>
Message-ID: <20040308031426.GH21071@cs.rice.edu>
References: <200403080027.i280RXIC041557@repoman.freebsd.org>
	<20040308005242.GG21071@cs.rice.edu> <200403071731.14880.peter@wemm.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200403071731.14880.peter@wemm.org>
User-Agent: Mutt/1.3.28i
X-Virus-Scanned: by amavis-20030616-p7 at cs.rice.edu
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: Peter Wemm <peter@FreeBSD.org>
Subject: Re: cvs commit: src/sys/i386/i386 vm_machdep.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Mar 2004 03:14:27 -0000

On Sun, Mar 07, 2004 at 05:31:14PM -0800, Peter Wemm wrote:
> ...
> 
> Meanwhile, would it be an idea to back out the Giant removal around the 
> kmem_free() in vm_machdep.c?  Its a rarely executed code path.

I see you backed it out.  That's fine.

> I wish there was a way to keep notes about this in the source.  Trying 
> to figure out the quirks of this stuff is painful.

I understand.  There are, however, very few cases like this one.  So,
please don't become gunshy about such changes.

Regards,
Alan