From owner-freebsd-hackers Thu Feb 27 16:56:17 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id QAA28554 for hackers-outgoing; Thu, 27 Feb 1997 16:56:17 -0800 (PST) Received: from parkplace.cet.co.jp (parkplace.cet.co.jp [202.32.64.1]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id QAA28416; Thu, 27 Feb 1997 16:53:39 -0800 (PST) Received: from localhost (michaelh@localhost) by parkplace.cet.co.jp (8.8.5/CET-v2.1) with SMTP id AAA07248; Fri, 28 Feb 1997 00:53:14 GMT Date: Fri, 28 Feb 1997 09:53:14 +0900 (JST) From: Michael Hancock To: Eivind Eklund cc: Brian Somers , hackers@freebsd.org, eivind@freebsd.org, bde@zeta.org.au, brian@utell.co.uk Subject: Re: Include files (in ppp) In-Reply-To: <3.0.32.19970227142902.00bccd30@dimaga.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-hackers@freebsd.org X-Loop: FreeBSD.org Precedence: bulk You might want to compare with what's on IIJ's server, ftp.iij.ad.jp. As I recall tony-o wrote IIJ-PPP and he is no longer at IIJ. I haven't been following it so I'm not sure how actively it's maintained. Regards, Mike On Thu, 27 Feb 1997, Eivind Eklund wrote: > At 01:23 AM 2/27/97 +0000, Brian Somers wrote: > >I'd suggest one of the following: > > > >- Leave it as it is (with osreldate.h adding partially to the chaos) > >- Remove all of the #ifs buts and whys (rationalle: If osreldate isn't > > in there, All the #if BSD etc stuff is useless anyway) > > I'd say this depend on a few things: > (A) How many patches to IIJ-PPP do we recieve? If there are a lot of > these, removing #ifdefs might disrupt merging. (Doesn't look like it from > the amount of commits, though.) > (B) Is IIJ-PPP actively developed anywhere outside FreeBSD? See (A). > (PPP+pktAlias doesn't count - I'll merge any changes from -current) > (C) Is IIJ-PPP from FreeBSD actively used by non-FreeBSD people? In this > case, we could pay them the courtesy of leaving it in. > > If none of these factors give us trouble, I'd say we cut the #ifdef's - > they clutter the code. However, the final choice is in Brian's hands - as > well as the responsibility for adding himself as maintainer in the Makefile > ;-) > > > Eivind Eklund perhaps@yes.no http://maybe.yes.no/perhaps/ eivind@freebsd.org >