Date: Tue, 28 Mar 1995 10:09:35 -0800 (PST) From: Poul-Henning Kamp <phk@ref.tfs.com> To: bde@zeta.org.au (Bruce Evans) Cc: bde@zeta.org.au, charnier@lirmm.fr, hackers@FreeBSD.org Subject: Re: patches for -Wall in sbin Message-ID: <199503281809.KAA04654@ref.tfs.com> In-Reply-To: <199503281801.EAA30784@godzilla.zeta.org.au> from "Bruce Evans" at Mar 29, 95 04:01:15 am
next in thread | previous in thread | raw e-mail | index | archive | help
> >>Let me handle the patches for fsck. I have been (slowly) checking > >>phk's patches for -Wall for it. > >> > > >That code uses functions for writing warning and errors messages, that > >-Wall doesn't like. What a pity to not use the 4.4 interface for this > >(warnx, errx and al.). > > There should be warnings for bad args to warnx, etc. too :-). Anything > that supports printf-style error messages should be declared as > __attribute__((format(printf, m, n))) where `m' is the arg number of > the format string and `n' is the arg number of the first vararg. Splendid idea ! -- Poul-Henning Kamp <phk@login.dknet.dk> -- TRW Financial Systems, Inc. 'All relevant people are pertinent' && 'All rude people are impertinent' => 'no rude people are relevant'
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199503281809.KAA04654>