From owner-freebsd-hackers Tue Mar 28 10:10:32 1995 Return-Path: hackers-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id KAA22837 for hackers-outgoing; Tue, 28 Mar 1995 10:10:32 -0800 Received: from ref.tfs.com (ref.tfs.com [140.145.254.251]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id KAA22831 for ; Tue, 28 Mar 1995 10:10:31 -0800 Received: (from phk@localhost) by ref.tfs.com (8.6.8/8.6.6) id KAA04654; Tue, 28 Mar 1995 10:09:35 -0800 From: Poul-Henning Kamp Message-Id: <199503281809.KAA04654@ref.tfs.com> Subject: Re: patches for -Wall in sbin To: bde@zeta.org.au (Bruce Evans) Date: Tue, 28 Mar 1995 10:09:35 -0800 (PST) Cc: bde@zeta.org.au, charnier@lirmm.fr, hackers@FreeBSD.org In-Reply-To: <199503281801.EAA30784@godzilla.zeta.org.au> from "Bruce Evans" at Mar 29, 95 04:01:15 am Content-Type: text Content-Length: 767 Sender: hackers-owner@FreeBSD.org Precedence: bulk > >>Let me handle the patches for fsck. I have been (slowly) checking > >>phk's patches for -Wall for it. > >> > > >That code uses functions for writing warning and errors messages, that > >-Wall doesn't like. What a pity to not use the 4.4 interface for this > >(warnx, errx and al.). > > There should be warnings for bad args to warnx, etc. too :-). Anything > that supports printf-style error messages should be declared as > __attribute__((format(printf, m, n))) where `m' is the arg number of > the format string and `n' is the arg number of the first vararg. Splendid idea ! -- Poul-Henning Kamp -- TRW Financial Systems, Inc. 'All relevant people are pertinent' && 'All rude people are impertinent' => 'no rude people are relevant'