From owner-svn-src-projects@FreeBSD.ORG Thu Feb 18 02:37:24 2010 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 53B60106566B; Thu, 18 Feb 2010 02:37:24 +0000 (UTC) (envelope-from nwhitehorn@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 4288C8FC17; Thu, 18 Feb 2010 02:37:24 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o1I2bOPj030269; Thu, 18 Feb 2010 02:37:24 GMT (envelope-from nwhitehorn@svn.freebsd.org) Received: (from nwhitehorn@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o1I2bOVp030267; Thu, 18 Feb 2010 02:37:24 GMT (envelope-from nwhitehorn@svn.freebsd.org) Message-Id: <201002180237.o1I2bOVp030267@svn.freebsd.org> From: Nathan Whitehorn Date: Thu, 18 Feb 2010 02:37:24 +0000 (UTC) To: src-committers@freebsd.org, svn-src-projects@freebsd.org X-SVN-Group: projects MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r204026 - projects/ppc64/sys/powerpc/aim X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Feb 2010 02:37:24 -0000 Author: nwhitehorn Date: Thu Feb 18 02:37:23 2010 New Revision: 204026 URL: http://svn.freebsd.org/changeset/base/204026 Log: Fix a data corruption bug during swap. This bug also exists on 32-bit OEA, and should be applied there after some soaking and correctness checks. Discussed with: grehan Modified: projects/ppc64/sys/powerpc/aim/mmu_oea64.c Modified: projects/ppc64/sys/powerpc/aim/mmu_oea64.c ============================================================================== --- projects/ppc64/sys/powerpc/aim/mmu_oea64.c Thu Feb 18 02:06:57 2010 (r204025) +++ projects/ppc64/sys/powerpc/aim/mmu_oea64.c Thu Feb 18 02:37:23 2010 (r204026) @@ -2054,6 +2054,10 @@ moea64_remove_all(mmu_t mmu, vm_page_t m moea64_pvo_remove(pvo, -1); PMAP_UNLOCK(pmap); } + if ((m->flags & PG_WRITEABLE) && moea64_is_modified(mmu, m)) { + moea64_attr_clear(m, LPTE_CHG); + vm_page_dirty(m); + } vm_page_flag_clear(m, PG_WRITEABLE); } @@ -2472,10 +2476,8 @@ moea64_query_bit(vm_page_t m, u_int64_t struct pvo_entry *pvo; struct lpte *pt; -#if 0 if (moea64_attr_fetch(m) & ptebit) return (TRUE); -#endif LIST_FOREACH(pvo, vm_page_to_pvoh(m), pvo_vlink) { MOEA_PVO_CHECK(pvo); /* sanity check */