From owner-cvs-sys  Tue Sep 16 10:51:01 1997
Return-Path: <owner-cvs-sys>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id KAA08878
          for cvs-sys-outgoing; Tue, 16 Sep 1997 10:51:01 -0700 (PDT)
Received: from alpo.whistle.com (alpo.whistle.com [207.76.204.38])
          by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id KAA08855;
          Tue, 16 Sep 1997 10:50:29 -0700 (PDT)
Received: (from daemon@localhost)
	by alpo.whistle.com (8.8.5/8.8.5) id KAA19999;
	Tue, 16 Sep 1997 10:47:34 -0700 (PDT)
Received: from current1.whistle.com(207.76.205.22)
 via SMTP by alpo.whistle.com, id smtpd019993; Tue Sep 16 17:47:24 1997
Message-ID: <341EC602.167EB0E7@whistle.com>
Date: Tue, 16 Sep 1997 10:46:42 -0700
From: Julian Elischer <julian@whistle.com>
Organization: Whistle Communications
X-Mailer: Mozilla 3.0Gold (X11; I; FreeBSD 2.2-CURRENT i386)
MIME-Version: 1.0
To: Bruce Evans <bde@FreeBSD.ORG>
CC: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/kern subr_log.c subr_rlist.c tty_pty.c          tty_snoop.c tty_tty.c uipc_domain.c vfs_subr.c src/sys/net bpf.c          netisr.h route.c src/sys/netinet igmp.c in_proto.c ip_fw.h          tcp_subr.c src/sys/sys buf.h exe
References: <199709161144.EAA18871@freefall.freebsd.org>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-sys@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

Bruce Evans wrote:
I think this has been discussed before..
but...
WHY!!!!!

in the example given I think the original made more sense,
and didn't we vote to stop adding more of the stupid __P() stuff?

from this commit.....


*************** 
*** 179,186 ****
  static        void    *ctty_devfs_token;
  #endif
  
  static void
! ctty_drvinit(void *unused)
  {
        dev_t dev;
  
--- 179,188 ----
  static        void    *ctty_devfs_token;
  #endif
  
+ static void ctty_drvinit __P((void *unused));
  static void
! ctty_drvinit(unused)
!       void *unused;
  {
        dev_t dev;
> bde         1997/09/16 04:44:06 PDT
> 
>   Modified files:
>     sys/kern             subr_log.c subr_rlist.c tty_pty.c
>                          tty_snoop.c tty_tty.c uipc_domain.c
>                          vfs_subr.c
>     sys/net              bpf.c netisr.h route.c
>     sys/netinet          igmp.c in_proto.c ip_fw.h tcp_subr.c
>     sys/sys              buf.h exec.h inflate.h
>   Log:
>   Fixed gratuitous ANSIisms.
> 
>   Revision  Changes    Path
>   1.24      +4 -2      src/sys/kern/subr_log.c
>   1.23      +5 -3      src/sys/kern/subr_rlist.c
>   1.47      +4 -2      src/sys/kern/tty_pty.c
>   1.21      +3 -1      src/sys/kern/tty_snoop.c
>   1.19      +4 -2      src/sys/kern/tty_tty.c
>   1.18      +8 -3      src/sys/kern/uipc_domain.c
>   1.104     +16 -8     src/sys/kern/vfs_subr.c
>   1.34      +6 -3      src/sys/net/bpf.c
>   1.13      +2 -2      src/sys/net/netisr.h
>   1.44      +9 -5      src/sys/net/route.c
>   1.23      +2 -2      src/sys/netinet/igmp.c
>   1.41      +2 -2      src/sys/netinet/in_proto.c
>   1.29      +2 -2      src/sys/netinet/ip_fw.h
>   1.37      +5 -4      src/sys/netinet/tcp_subr.c
>   1.41      +2 -2      src/sys/sys/buf.h
>   1.17      +2 -2      src/sys/sys/exec.h
>   1.9       +3 -3      src/sys/sys/inflate.h