From owner-p4-projects Thu May 16 22:14:43 2002 Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id A65F737B403; Thu, 16 May 2002 22:14:38 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from evilpete.dyndns.org (12-232-26-46.client.attbi.com [12.232.26.46]) by hub.freebsd.org (Postfix) with ESMTP id 90FFE37B40D; Thu, 16 May 2002 22:14:36 -0700 (PDT) Received: from overcee.wemm.org ([10.0.0.3]) by evilpete.dyndns.org (8.11.6/8.11.6) with ESMTP id g4H5ES107077; Thu, 16 May 2002 22:14:36 -0700 (PDT) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by overcee.wemm.org (Postfix) with ESMTP id 1701B380A; Thu, 16 May 2002 22:14:28 -0700 (PDT) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Jonathan Mini Cc: Julian Elischer , jhb@freebsd.org, Perforce Change Reviews Subject: Re: PERFORCE change 11120 for review In-Reply-To: <20020516214147.B25907@stylus.haikugeek.com> Date: Thu, 16 May 2002 22:14:28 -0700 From: Peter Wemm Message-Id: <20020517051428.1701B380A@overcee.wemm.org> Sender: owner-p4-projects@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Jonathan Mini wrote: > Julian Elischer [julian@elischer.org] wrote : > > plus other comments already noted by others.. > > (tabbing and sleeping with locks) > > The tabbing is fixed. As for sleeping with locks in UMA functions, Jeff > said that it is ok to sleep for a short time, but long-term sleeps aren't > such a good idea (makes sense). > > The only problem he foresaw was that the init/fini functions could be called > by the pager daemon, but I don't see any problem there either. Somewhere along the way we were planning to put in code that checked for things that *might* call tsleep() and trap mutexes being held. I dont know if the UMA stuff calls tsleep (directly or indirectly) or not, but it was my understanding that it is a Bad Idea(TM) to call anything that can tsleep with a mutex held. Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message