From nobody Sun Jul 16 01:13:00 2023 X-Original-To: virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4R3RzY6gQzz4nVbr for ; Sun, 16 Jul 2023 01:13:13 +0000 (UTC) (envelope-from mgrooms@shrew.net) Received: from mx2.shrew.net (mx2.shrew.net [38.97.5.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4R3RzX6RY8z3Q4b for ; Sun, 16 Jul 2023 01:13:12 +0000 (UTC) (envelope-from mgrooms@shrew.net) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of mgrooms@shrew.net designates 38.97.5.132 as permitted sender) smtp.mailfrom=mgrooms@shrew.net; dmarc=none Received: from mail.shrew.net (mail.shrew.prv [10.24.10.20]) by mx2.shrew.net (8.15.2/8.15.2) with ESMTP id 36G1D6Ma010924 for ; Sat, 15 Jul 2023 20:13:06 -0500 (CDT) (envelope-from mgrooms@shrew.net) Received: from [10.22.200.32] (unknown [136.49.230.220]) by mail.shrew.net (Postfix) with ESMTPSA id 32EAE194C30 for ; Sat, 15 Jul 2023 20:13:01 -0500 (CDT) Message-ID: Date: Sat, 15 Jul 2023 20:13:00 -0500 List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: BHYVE SNAPSHOT image format proposal Content-Language: en-US To: virtualization@freebsd.org References: <67FDC8A8-86A6-4AE4-85F0-FF7BEF9F2F06@gmail.com> <6b98da58a5bd8e83bc466efa20b5a900298210aa.camel@FreeBSD.org> <8387AC83-6667-48E5-A3FA-11475EA96A5F@gmail.com> <986A83D8-E0E0-4030-9369-A5B3500E27C6@gmail.com> <79fabe94-b800-c713-48ea-518da1f74e4d@shrew.net> <3973013d-c183-360f-d7ca-ca822859c23d@shrew.net> <3a037482-2e6c-667f-1979-d5b612e506ec@shrew.net> From: Matthew Grooms In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx2.shrew.net [10.24.10.11]); Sat, 15 Jul 2023 20:13:06 -0500 (CDT) X-Spamd-Result: default: False [-3.29 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.99)[-0.994]; R_SPF_ALLOW(-0.20)[+mx]; MIME_GOOD(-0.10)[text/plain]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:174, ipnet:38.0.0.0/8, country:US]; MLMMJ_DEST(0.00)[virtualization@freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; BLOCKLISTDE_FAIL(0.00)[136.49.230.220:server fail,38.97.5.132:server fail]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[shrew.net]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_LAST(0.00)[]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_ALL(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[virtualization@freebsd.org]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; MID_RHS_MATCH_FROM(0.00)[] X-Rspamd-Queue-Id: 4R3RzX6RY8z3Q4b X-Spamd-Bar: --- X-ThisMailContainsUnwantedMimeParts: N On 7/15/23 12:31, Rob Wing wrote: > > On Saturday, July 15, 2023, Matthew Grooms > wrote: > > > We'll overlook the fact that it does attempt to consolidate files ( > 2 vs 3 ) and that there's no feedback requesting further > consolidation after being open for two years, but noted. > > You may as well abandon https://reviews.freebsd.org/D29262 > , for these reasons alone: > Thanks for the feedback. In the future, please feel free to add your concerns to the code review. It would be extremely helpful. > - JSON doesn't support storing binary data I don't know how to state it more clearly: Making binary copies of the data structures is the problem. Something tells me that you'll continue to ignore this, so I'll stop saying it. > - a snapshot should be contained in a single file Heard. A single file. > > The UPB patch addresses the above. Vitaliy's patch does nothing to > address any of it. If one is going to be proposed as an alternative > to the other, it better solve the same problems as then some. > > The UBP patch is not an alternative - show me another hypervisor that > uses JSON as their snapshot format. > Heard. JSON is bad. > The silence is real. > > > No, it's not. I've given you feedback multiple times. I'm very aware. The silence I was referring to wasn't yours. Feel free to re-read for context. Rob, I'm not hear to argue with you. I've shared all the opinions I feel are relevant to the file format proposal and would prefer not to waste the list's time. Thanks, -Matthew