Date: Mon, 31 Dec 2012 12:07:51 -0600 From: Jeremy Messenger <mezz.freebsd@gmail.com> To: Jason Helfman <jgh@freebsd.org> Cc: svn-ports-head@freebsd.org, Baptiste Daroussin <bapt@freebsd.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org, gahr@freebsd.org, "Jason E. Hale" <jhale@freebsd.org> Subject: Re: svn commit: r309705 - in head/irc: . dxirc Message-ID: <CADLFtte1az5hK01ZqDnbyn_1GqLr%2B7ZSVA%2BFmzcCvcc39bS1qA@mail.gmail.com> In-Reply-To: <CAMuy=%2BiMANJ_3G9LHwsxPrai%2BxhE3Ryj9rd8j0Z0zodGg82Wmw@mail.gmail.com> References: <201212310346.qBV3kR0W049479@svn.freebsd.org> <8701822.2t1vcGT59x@mocha.verizon.net> <CAMuy=%2BiMANJ_3G9LHwsxPrai%2BxhE3Ryj9rd8j0Z0zodGg82Wmw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Dec 31, 2012 at 11:49 AM, Jason Helfman <jgh@freebsd.org> wrote:
> On Mon, Dec 31, 2012 at 6:06 AM, Jason E. Hale <jhale@freebsd.org> wrote:
>>
>> On Monday, December 31, 2012 03:46:27 Jason Helfman wrote:
>> > Added: head/irc/dxirc/Makefile
>> >
>> > ============================================================================
>> > --- /dev/null 00:00:00 1970 (empty, because file is newly added)
>> > +++ head/irc/dxirc/Makefile Mon Dec 31 03:46:26 2012
>> > (r309705)
>> > @@ -0,0 +1,80 @@
>> >
>> > +LICENSE= GPLv3
>> > +LICENSE_FILE= ${WRKSRC}/COPYING
>>
>> LICENSE_FILE should be dropped for standard license
>>
>
> Did you compare the license files before making this comment?
>
>> > +LIB_DEPENDS= FOX-1:${PORTSDIR}/x11-toolkits/fox16
>>
>> The library name is FOX-1.6 despite portlint warnings ".6" is not an ABI
>> version number.
>>
>
> Another reason to drop the ABI warning from portlint. Builds still passed
> with, and without it. I will restore it. IMHO I am not in favor of portlint
> warnings for this.
I will have to agree with on this part. Worked with PRs in past days
and I can say that many users are making that kind of mistakes. Even a
few of committers made same mistakes. A lot of people just assume that
the dot means that it's shared library version without recheck.
While I am here. It would be great if you (gahr@) add 'ltverhack' in
the USE_GNOME and add USE_AUTOTOOLS=libtool in x11-toolkits/fox* to
avoid bump shared library version at the every minor release. Does the
fox really break ABI at the every minor version? If you try my suggest
and I am not surprised if it will be 1.6.so.0 that won't get change
for very long time (possible years).
>> > +OPTIONS_DEFINE= NLS TRAY IPV6 SSL LUA ENCHANT NOTIFY
>> > +OPTIONS_DEFAULT= NLS TRAY IPV6 SSL LUA
>>
>> NLS doesn't need to be in OPTIONS_DEFAULT...it is already default. Might
>> as
>> well add DOCS to OPTIONS_DEFINE too.
>>
> I wanted to honor what the contributor wanted for defaults in the future if
> the defaults ever are to change. I don't see how naming them explicitly is a
> problem.
>
>>
>> > Added: head/irc/dxirc/pkg-plist
>> >
>> > ============================================================================
>> > == --- /dev/null 00:00:00 1970 (empty, because file is newly
>> > added)
>> > +++ head/irc/dxirc/pkg-plist Mon Dec 31 03:46:26 2012 (r309705)
>> > @@ -0,0 +1,297 @@
>> > +%%DATADIR%%/COPYING
>>
>> Since LICENSE is already defined, the installation of an additional
>> license
>> file should be squashed.
>
>
> Good catch. Thanks!
>
>>
>>
>> > +@dirrm share/applications
>>
>> This should be a @dirrmtry since it is a shared directory.
>>
>
> Good catch. Thanks!
>
> -jgh
--
mezz.freebsd@gmail.com - mezz@FreeBSD.org
FreeBSD GNOME Team
http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLFtte1az5hK01ZqDnbyn_1GqLr%2B7ZSVA%2BFmzcCvcc39bS1qA>