From owner-svn-ports-head@FreeBSD.ORG Mon Dec 31 18:08:00 2012 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 127429AC; Mon, 31 Dec 2012 18:08:00 +0000 (UTC) (envelope-from mezz.freebsd@gmail.com) Received: from mail-vc0-f179.google.com (mail-vc0-f179.google.com [209.85.220.179]) by mx1.freebsd.org (Postfix) with ESMTP id 143548FC08; Mon, 31 Dec 2012 18:07:58 +0000 (UTC) Received: by mail-vc0-f179.google.com with SMTP id p1so12812559vcq.24 for ; Mon, 31 Dec 2012 10:07:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=SryKP4Kn1ncKnySaZFu4b/XS8aSXXVUlPfi7JFNqZig=; b=WNzSKkfOggWSfSwXLBGQ+r3nzkjmrkVVfJ6OX//UTgPuq6rgCEulyTuz9wPxM9UDoo 3uoCExUsBSfjIu8f0oRSXZUwZPjuIMhAabVD3xlblbY5BLBhjzVUkaHDhFdiywgvvnkm YQhpj/MbsmW5f07RXYBIHA94Xavso8J6VNUtM90+oVAZbGNEV8xqFWBoaV+atCmDHGaq R2D6twXRSKiNAu9OMvsbLjIrh9rNuhGA1+fHHXrCvOg/54Pwf0jB/9jqHVy8v38ANycQ cfEia+d2LMM6vz8LW0w3zbC0Ig7uJnaydMTeaVkWNSFBbHAZ6apnLEf0S2Zxb5WIJOLF nuOQ== MIME-Version: 1.0 Received: by 10.52.31.197 with SMTP id c5mr56732141vdi.65.1356977272109; Mon, 31 Dec 2012 10:07:52 -0800 (PST) Received: by 10.58.189.36 with HTTP; Mon, 31 Dec 2012 10:07:51 -0800 (PST) In-Reply-To: References: <201212310346.qBV3kR0W049479@svn.freebsd.org> <8701822.2t1vcGT59x@mocha.verizon.net> Date: Mon, 31 Dec 2012 12:07:51 -0600 Message-ID: Subject: Re: svn commit: r309705 - in head/irc: . dxirc From: Jeremy Messenger To: Jason Helfman Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-ports-head@freebsd.org, Baptiste Daroussin , svn-ports-all@freebsd.org, ports-committers@freebsd.org, gahr@freebsd.org, "Jason E. Hale" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Dec 2012 18:08:00 -0000 On Mon, Dec 31, 2012 at 11:49 AM, Jason Helfman wrote: > On Mon, Dec 31, 2012 at 6:06 AM, Jason E. Hale wrote: >> >> On Monday, December 31, 2012 03:46:27 Jason Helfman wrote: >> > Added: head/irc/dxirc/Makefile >> > >> > ============================================================================ >> > --- /dev/null 00:00:00 1970 (empty, because file is newly added) >> > +++ head/irc/dxirc/Makefile Mon Dec 31 03:46:26 2012 >> > (r309705) >> > @@ -0,0 +1,80 @@ >> > >> > +LICENSE= GPLv3 >> > +LICENSE_FILE= ${WRKSRC}/COPYING >> >> LICENSE_FILE should be dropped for standard license >> > > Did you compare the license files before making this comment? > >> > +LIB_DEPENDS= FOX-1:${PORTSDIR}/x11-toolkits/fox16 >> >> The library name is FOX-1.6 despite portlint warnings ".6" is not an ABI >> version number. >> > > Another reason to drop the ABI warning from portlint. Builds still passed > with, and without it. I will restore it. IMHO I am not in favor of portlint > warnings for this. I will have to agree with on this part. Worked with PRs in past days and I can say that many users are making that kind of mistakes. Even a few of committers made same mistakes. A lot of people just assume that the dot means that it's shared library version without recheck. While I am here. It would be great if you (gahr@) add 'ltverhack' in the USE_GNOME and add USE_AUTOTOOLS=libtool in x11-toolkits/fox* to avoid bump shared library version at the every minor release. Does the fox really break ABI at the every minor version? If you try my suggest and I am not surprised if it will be 1.6.so.0 that won't get change for very long time (possible years). >> > +OPTIONS_DEFINE= NLS TRAY IPV6 SSL LUA ENCHANT NOTIFY >> > +OPTIONS_DEFAULT= NLS TRAY IPV6 SSL LUA >> >> NLS doesn't need to be in OPTIONS_DEFAULT...it is already default. Might >> as >> well add DOCS to OPTIONS_DEFINE too. >> > I wanted to honor what the contributor wanted for defaults in the future if > the defaults ever are to change. I don't see how naming them explicitly is a > problem. > >> >> > Added: head/irc/dxirc/pkg-plist >> > >> > ============================================================================ >> > == --- /dev/null 00:00:00 1970 (empty, because file is newly >> > added) >> > +++ head/irc/dxirc/pkg-plist Mon Dec 31 03:46:26 2012 (r309705) >> > @@ -0,0 +1,297 @@ >> > +%%DATADIR%%/COPYING >> >> Since LICENSE is already defined, the installation of an additional >> license >> file should be squashed. > > > Good catch. Thanks! > >> >> >> > +@dirrm share/applications >> >> This should be a @dirrmtry since it is a shared directory. >> > > Good catch. Thanks! > > -jgh -- mezz.freebsd@gmail.com - mezz@FreeBSD.org FreeBSD GNOME Team http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org