From owner-svn-src-head@FreeBSD.ORG  Tue Nov 29 16:36:00 2011
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3F151106564A;
	Tue, 29 Nov 2011 16:36:00 +0000 (UTC)
	(envelope-from fjoe@samodelkin.net)
Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com
	[209.85.216.54])
	by mx1.freebsd.org (Postfix) with ESMTP id CF9EB8FC1D;
	Tue, 29 Nov 2011 16:35:59 +0000 (UTC)
Received: by qadc10 with SMTP id c10so5419217qad.13
	for <multiple recipients>; Tue, 29 Nov 2011 08:35:59 -0800 (PST)
MIME-Version: 1.0
Received: by 10.182.45.6 with SMTP id i6mr13612691obm.3.1322584558960; Tue, 29
	Nov 2011 08:35:58 -0800 (PST)
Sender: fjoe@samodelkin.net
Received: by 10.182.76.225 with HTTP; Tue, 29 Nov 2011 08:35:58 -0800 (PST)
X-Originating-IP: [80.89.199.122]
In-Reply-To: <20111129090043.0ac7fa56@kan.dyndns.org>
References: <201111290838.pAT8clOa031710@svn.freebsd.org>
	<20111129090043.0ac7fa56@kan.dyndns.org>
Date: Tue, 29 Nov 2011 22:35:58 +0600
X-Google-Sender-Auth: FmZDv4WQ1MaWLzydocXjnTMTUOI
Message-ID: <CADe0-4=C=50jzkH4Tvwx+q3bUxpBQ0tLNGvATu7CEK59Kk6bxQ@mail.gmail.com>
From: Max Khon <fjoe@FreeBSD.org>
To: Alexander Kabaev <kabaev@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
X-Content-Filtered-By: Mailman/MimeDel 2.1.5
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r228124 - in head: share/mk sys/conf
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Nov 2011 16:36:00 -0000

Alexander,

On Tue, Nov 29, 2011 at 9:00 PM, Alexander Kabaev <kabaev@gmail.com> wrote:

> Author: fjoe
> > Date: Tue Nov 29 08:38:47 2011
> > New Revision: 228124
> > URL: http://svn.freebsd.org/changeset/base/228124
> >
> > Log:
> >   Conditionalize ctfconvert/ctfmerge runs on make level (.if/.endif)
> > instead of executing a shell on every object or executable/library
> > file.
> >   This shaves off more than 30,000 shell invocations during
> > buildworld.
>
> Have you looked as to _why_ it was done through shell invocation in the
> first place before removing it? You now have broken CTF support in
> cases where WITH_CTF is set not on make command line or in environment,
> but say in each individual Makefile.


I tested all the use-cases mentioned in the original commit but it looks
like I specified the location of modified share/mk incorrectly when I did
WITH_CTF userland tests.

Should be fixed now. Sorry for the breakage.

Max