From owner-cvs-src@FreeBSD.ORG Sun Mar 6 05:16:12 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2080516A4CF; Sun, 6 Mar 2005 05:16:12 +0000 (GMT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4AB5243D1F; Sun, 6 Mar 2005 05:16:11 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.13.3/8.13.1) with ESMTP id j265FTxB003294; Sat, 5 Mar 2005 22:15:29 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Sat, 05 Mar 2005 22:16:00 -0700 (MST) Message-Id: <20050305.221600.35662653.imp@bsdimp.com> To: jeremie@le-hen.org From: "M. Warner Losh" In-Reply-To: <20050306050505.GA71191@obiwan.tataz.chchile.org> References: <200502280127.j1S1ROkh066282@repoman.freebsd.org> <20050306050505.GA71191@obiwan.tataz.chchile.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/cardbus cardbus.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Mar 2005 05:16:12 -0000 In message: <20050306050505.GA71191@obiwan.tataz.chchile.org> Jeremie Le Hen writes: : Hi, : : On Mon, Feb 28, 2005 at 01:27:24AM +0000, Warner Losh wrote: : > imp 2005-02-28 01:27:24 UTC : > : > FreeBSD src repository : > : > Modified files: : > sys/dev/cardbus cardbus.c : > Log: : > There were two calls to cardbus_do_cis when cardbus_do_cis changed, : > yet I only changed one of them. So when we loaded drivers, we'd fail : > to allocate resources correct. : > : > This pointed out that we were doing the wrong thing when we failed to : > attach a child. We released all the resources and almost deleted the : > child. Instead, we should keep the resources allocated so when/if a : > driver is loaded, we can go w/o having to allocate them. We use : > pci_cfg_save/restore to restore the BARs with these resources. : > : > This seems to fix the problems that we were seeing that I thought : > might have magically gone away in the last revision of cardbus.c (but : > really didn't). : > : > Noticed by: avatar (nicely done!) : > : > Revision Changes Path : > 1.49 +5 -7 src/sys/dev/cardbus/cardbus.c : : This commit prevents my rl(4) network card from attaching. Reverting : to rev 1.48 makes things goes right. Feel free to contact me if you : need more details. Attaching how? On kldload or in general? What kind of card do you have? What messages are involved? Warner