From owner-freebsd-bugs@FreeBSD.ORG Tue Apr 11 09:40:23 2006 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 296CE16A407 for ; Tue, 11 Apr 2006 09:40:23 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id CCE0343D5D for ; Tue, 11 Apr 2006 09:40:17 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k3B9eHwW029611 for ; Tue, 11 Apr 2006 09:40:17 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k3B9eHQO029610; Tue, 11 Apr 2006 09:40:17 GMT (envelope-from gnats) Resent-Date: Tue, 11 Apr 2006 09:40:17 GMT Resent-Message-Id: <200604110940.k3B9eHQO029610@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Sebastian Werner Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 12F0016A401 for ; Tue, 11 Apr 2006 09:37:27 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id B351443D48 for ; Tue, 11 Apr 2006 09:37:26 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k3B9bQ3N014279 for ; Tue, 11 Apr 2006 09:37:26 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id k3B9bQF2014278; Tue, 11 Apr 2006 09:37:26 GMT (envelope-from nobody) Message-Id: <200604110937.k3B9bQF2014278@www.freebsd.org> Date: Tue, 11 Apr 2006 09:37:26 GMT From: Sebastian Werner To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Cc: Subject: misc/95617: /usr/src/etc/Makefile contains logical error X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Apr 2006 09:40:23 -0000 >Number: 95617 >Category: misc >Synopsis: /usr/src/etc/Makefile contains logical error >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Apr 11 09:40:16 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Sebastian Werner >Release: 6.0 >Organization: >Environment: FreeBSD blackwing.hawo.stw.uni-erlangen.de 6.0-RELEASE FreeBSD 6.0-RELEASE #0: Thu Nov 3 09:36:13 UTC 2005 root@blackwing.hawo.stw.uni-erlangen.de:/usr/obj/usr/src/sys/BLACKSTATION i386 >Description: During make distribution I got an error 64 while trying to install ssh in /usr/src/etc . I got NO_CRYPT set (jail install stuff), but NOT NO_OPENSSL and NO_OPENSSH. The error is happening, because the Makefile defines, that SSH= is not set, because NO_CRYPT is set. (line 27 of /usr/local/etc/Makefile) But later in line 115, the variable SSH is used, because neither NO_OPENSSL nor NO_OPENSSH is set. In this case there is no check for NO_CRYPT. >How-To-Repeat: Set NO_CRYPT but do not set NO_OPENSSH make distribution >Fix: --- /usr/local/etc/Makefile Tue Apr 11 01:52:10 2006 +++ usr/local/etc/Makefilee Tue Apr 11 01:54:28 2006 @@ -111,6 +111,7 @@ .if !defined(NO_SENDMAIL) cd ${.CURDIR}/sendmail; ${MAKE} distribution .endif +.if !defined(NO_CRYPT) .if !defined(NO_OPENSSL) .if !defined(NO_OPENSSH) cd ${.CURDIR}; ${INSTALL} -o ${BINOWN} -g ${BINGRP} -m 644 \ @@ -118,6 +119,7 @@ .endif cd ${.CURDIR}; ${INSTALL} -o ${BINOWN} -g ${BINGRP} -m 644 \ ${SSL} ${DESTDIR}/etc/ssl +.endif .endif .if !defined(NO_KERBEROS) cd ${.CURDIR}/root; \ >Release-Note: >Audit-Trail: >Unformatted: