From owner-svn-ports-all@freebsd.org  Tue Nov 14 10:44:04 2017
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id BF854DBAA61;
 Tue, 14 Nov 2017 10:44:04 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id A2B6A795AD;
 Tue, 14 Nov 2017 10:44:04 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id 098DA19BE5; Tue, 14 Nov 2017 10:44:04 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
Subject: Re: svn commit: r454171 - head/multimedia/libvpx
References: <201711141014.vAEAEjpT071974@repo.freebsd.org>
 <20171114102535.GA56721@FreeBSD.org>
Date: Tue, 14 Nov 2017 11:44:00 +0100
In-Reply-To: <20171114102535.GA56721@FreeBSD.org> (Alexey Dokuchaev's message
 of "Tue, 14 Nov 2017 10:25:35 +0000")
Message-ID: <tvxx-jg27-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Nov 2017 10:44:04 -0000

Alexey Dokuchaev <danfe@FreeBSD.org> writes:

> On Tue, Nov 14, 2017 at 10:14:45AM +0000, Jan Beich wrote:
>
>> New Revision: 454171
>> URL: https://svnweb.freebsd.org/changeset/ports/454171
>> 
>> Log:
>>   multimedia/libvpx: unbreak on amd64 after r454153
>>   
>>   Pointy hat to:	jbeich
>> 
>> Modified:
>>   head/multimedia/libvpx/Makefile   (contents, props changed)
>>   head/multimedia/libvpx/distinfo   (contents, props changed)
>> 
>> Modified: head/multimedia/libvpx/Makefile
>> ==============================================================================
>> --- head/multimedia/libvpx/Makefile	Tue Nov 14 10:05:12 2017	(r454170)
>> +++ head/multimedia/libvpx/Makefile	Tue Nov 14 10:14:45 2017	(r454171)
>> @@ -7,6 +7,9 @@ DISTVERSION=	1.6.1
>>  PORTREVISION=	2
>>  CATEGORIES=	multimedia
>>  
>> +PATCH_SITES=	https://github.com/${GH_ACCOUNT}/${GH_PROJECT}/commit/
>> +PATCHFILES=	bc4bc9b6223d.patch:-p1
>> 
>> @@ -1,3 +1,5 @@
>>  TIMESTAMP = 1484252847
>>  SHA256 (webmproject-libvpx-v1.6.1_GH0.tar.gz) = cda8bb6f0e4848c018177d3a576fa83ed96d762554d7010fe4cfb9d70c22e588
>>  SIZE (webmproject-libvpx-v1.6.1_GH0.tar.gz) = 2493087
>> +SHA256 (bc4bc9b6223d.patch) = cba3b69f1b8f34042802c076b46cf96bca2b4af028aeaf64e9b03ea8507c649e
>> +SIZE (bc4bc9b6223d.patch) = 2319
>
> Actually, could you add a real 2319-byte patch file under files/ instead?
> Last time I wanted to build some older version of `devel/android-tools-adb'
> which has the same "bug" and could not because the patch was no longer
> fetchable.  Thank you,

Why it wasn't fetchable? The GitHub mirror should be identical and is
already used to fetch the main distfile. Provide more details.

I use PATCHFILES to denote unmodified fixes from upstream. Putting them
under files/ requires generating with --no-prefix and pacifying portlint
via "make makepatch". That'd be no fun if more than one patch touches
the same files.