From owner-svn-src-head@freebsd.org Wed Jul 22 15:31:56 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 27D889A88E8; Wed, 22 Jul 2015 15:31:56 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-oi0-f49.google.com (mail-oi0-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E7D1D1D01; Wed, 22 Jul 2015 15:31:55 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by oige126 with SMTP id e126so146106888oig.0; Wed, 22 Jul 2015 08:31:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=Uz3DfMUaE4E0jXT7IRWPxvY1dLhI/8lUCv25zkFkZi0=; b=UhxBVBHhrPy29J70HPDjBF3JtADT/JmEBw4nh4oTTXsTg8cuCr1TuKSqoMFeuIhY9G 1I6uGu//HixLMNlhwKOWNphAEOvly4BUXZlTPfLgjZRjmzy7IkhLjskmPYyAR7hQdrHQ lrc5zDE/kNfPmcT0teA37HjQ4wA4CcqL3g5U4pBOsJSaDHbVWciCfpilYVguefapswZW 3uPcAn3w2tm630hDfzyPJQTreTPp+j4K4tnpWNIy4SXymbnpAMyl+ZmfPBPJLn53U8FN ODkiHHOykpzcm/b6L6IWNzEFLWcWfok2xsRVe3nONZ1LozrpLYSuuzOEesS1iZrKGPRT Ol5g== X-Received: by 10.60.62.235 with SMTP id b11mr3412174oes.18.1437579109675; Wed, 22 Jul 2015 08:31:49 -0700 (PDT) Received: from mail-oi0-f42.google.com (mail-oi0-f42.google.com. [209.85.218.42]) by smtp.gmail.com with ESMTPSA id r3sm942482oia.22.2015.07.22.08.31.49 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Jul 2015 08:31:49 -0700 (PDT) Received: by oige126 with SMTP id e126so146106710oig.0; Wed, 22 Jul 2015 08:31:49 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.60.178.241 with SMTP id db17mr3368241oec.36.1437579109206; Wed, 22 Jul 2015 08:31:49 -0700 (PDT) Reply-To: cem@FreeBSD.org Received: by 10.76.58.17 with HTTP; Wed, 22 Jul 2015 08:31:49 -0700 (PDT) In-Reply-To: References: <201507212033.t6LKXbTj041660@repo.freebsd.org> Date: Wed, 22 Jul 2015 08:31:49 -0700 Message-ID: Subject: Re: svn commit: r285766 - in head/sys: conf dev/vt dev/vt/logo From: Conrad Meyer To: src-committers@freebsd.org Cc: Luiz Otavio O Souza , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jul 2015 15:31:56 -0000 On Wed, Jul 22, 2015 at 7:10 AM, Conrad Meyer wrote: > On Tue, Jul 21, 2015 at 9:26 PM, Luiz Otavio O Souza wrote: >> This seems to break kernels without 'device splash'. >> >> ... >> linking kernel.debug >> vt_core.o: In function `vtterm_cnprobe': >> /usr/src/sys/dev/vt/vt_core.c:1363: undefined reference to >> `vt_logo_sprite_height' >> vt_core.o: In function `vt_termsize': >> /usr/src/sys/dev/vt/vt_core.c:568: undefined reference to >> `vt_logo_sprite_height' >> vt_core.o: In function `vt_winsize': >> /usr/src/sys/dev/vt/vt_core.c:603: undefined reference to >> `vt_logo_sprite_height' >> vt_core.o: In function `vt_compute_drawable_area': >> /usr/src/sys/dev/vt/vt_core.c:642: undefined reference to >> `vt_logo_sprite_height' >> vt_core.o: In function `vt_mouse_event': >> /usr/src/sys/dev/vt/vt_core.c:1955: undefined reference to >> `vt_logo_sprite_height' >> vt_core.o:/usr/src/sys/dev/vt/vt_core.c:2632: more undefined >> references to `vt_logo_sprite_height' follow >> vt_core.o: In function `vt_flush': >> /usr/src/sys/dev/vt/vt_core.c:1213: undefined reference to >> `vtterm_draw_cpu_logos' >> /usr/src/sys/dev/vt/vt_core.c:1222: undefined reference to >> `vt_logo_sprite_height' >> vt_core.o: In function `vt_scrollmode_kbdevent': >> /usr/src/sys/dev/vt/vt_core.c:766: undefined reference to >> `vt_logo_sprite_height' >> *** [kernel.debug] Error code 1 > > This is addressed in https://reviews.freebsd.org/D3151 . Committed in r285794. Thanks for your patience, and apologies for breaking the build. Best, Conrad