From nobody Tue Aug 5 00:00:10 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bwtq12jfnz63h1L; Tue, 05 Aug 2025 00:00:29 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bwtq10ghgz3dHJ; Tue, 05 Aug 2025 00:00:29 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-af95ecfbd5bso322757266b.1; Mon, 04 Aug 2025 17:00:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754352023; x=1754956823; darn=freebsd.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=PptMeIbR4oHSVJEUt6GzWqMbv0iv3zJ01RaRh4BSM08=; b=AEdgSKfN29ANua4KaYe6Kz0e3Ue1w1yBmNSorDjOBTGnuxIvF06yMqap26v/eEI/Od xTbPS1d4EDUI1UPQ/LSsoiEM5Vnggk7po19ECkSZYTBE3SHweY+ZSyuvqKOpn0zw/862 RZnGEozvM2Fgvg9HzIl+Y+LIvLsUGUr6zRDxRy17+/piVCPgWoX1RnekKV8hbJ3hHneI F3S8nqq9EW/1tjojxd3IT/OLvqggknTDYmQbcsEmMYmc7qPM/BVoUD6Lf0N3Qy9AXgjG 6yRJxFJc8lOgDogViBTc709i9IS+f8w7wIne67CParxd/T7sQ5aZXt5OcAKxwnRHjelx fkpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754352023; x=1754956823; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PptMeIbR4oHSVJEUt6GzWqMbv0iv3zJ01RaRh4BSM08=; b=Y8yx5BM2CKAr7b3/FTnSqVHlWL+vHLI4EMI5/TPBddG6CloKLYiSCc/IJDdBaGMzg5 kjb3GT6/A9kXFoK+a3qgD04aPYeV9yiB1v93mVy1Iym58jl6nXl7h/9gOvupNx2OKurm TySLC+WUVKnxQemqiP1EVV+bSOGw/eIWka3C2kbDGmrZ0lIqbuPRAIJ16EupU/SAah25 F/DbhDgXiu1BirxUG+/P8kp4OnGGoke/1LHC0Xg5PQLCPWs0U+sfUBNbCqphVgtkaFEq XtMDF4m4vatpG08LBU5LaWjbGRkRKAoh79WwPyrX1dJRsdLiX3D0KAg2Kl5hXKqlQ34X tukA== X-Forwarded-Encrypted: i=1; AJvYcCUJzR9d1/oMeqooUsJLi6hMft2fhQ3vbtP5CNHkg2BD8rcT/UmqMK3a6HJJbkUCEWXO1QzA2v8E6nOm71NYtjc=@freebsd.org, AJvYcCUSPT9izFdNrUDgkAcuQCne1K6JLHO2lQ+WEglpAa3VkXZQaLFoBPHoD/09564j2O7pob9S5Q5kUX5vxXbJ/6oSKccG@freebsd.org, AJvYcCW7rR7L+bUX0M9d/oOrTKnjO7IaKOQqVVKgt+wVuJCR0eYKE2z0xgGUt7Zs3QnaMc5+9FUSZrM3Bp3+R9z1OLRv+JEZrqw=@freebsd.org X-Gm-Message-State: AOJu0YxyC21EcEOV5dcmAmdBN074D6XHj2ypLY0I5wQiInzpVIBaZxLo MD0eTY3s59Ashqjux71DyllqECFo693Qa8BEvYQtjuHgIIEZYvTQW6Q1KBFewswef4DNdvrviCt Foizh7/6N3YrU2zwVPYsdU5tcFnEQuHBo X-Gm-Gg: ASbGnct7t82FrpzpjTgmIms3kdXZK40QEtSP5NINFpOIMwzUOgjymIL/InC5IWe5fKJ 3o1XnqEakGuxBYaC95JwZ4WzZ/onr6cHWMpUOFWhNI+cxl71+uZjoNVZs4pyHsv1gY1XJToKB6K 98oOP1eLgnuPF+LdoXxqnp6kSb2qj0YB0np8eIAoyX2+w+x1/Z/NAQlfuliiZYgaZvruhP6Q6ut byIR1QQs7CRMXObH1CDQLwmXEed7LbW40EIMFs= X-Google-Smtp-Source: AGHT+IHV3JK7FpQCTXny6jOm9bNDTu+Qu9b9b9yPUB29IZLV1CPfEeCgJ3XUHRSXmJ9C/grkveJa//xBPVb+cyyYJz4= X-Received: by 2002:a17:906:f192:b0:af9:44fe:dea1 with SMTP id a640c23a62f3a-af944fee3b8mr814360066b.23.1754352022431; Mon, 04 Aug 2025 17:00:22 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <202508042339.574NdNmf032977@gitrepo.freebsd.org> In-Reply-To: From: Rick Macklem Date: Mon, 4 Aug 2025 17:00:10 -0700 X-Gm-Features: Ac12FXyQzN6vGD1dponzZmNCNIiDYk1KJIHZMYmUBDEc8nSCNXgzh-zLTdbPmHw Message-ID: Subject: Re: git: 51affb7e9716 - main - nfscl: Fix GetACL so that it does not want a reply cached To: Jessica Clarke Cc: Rick Macklem , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4bwtq10ghgz3dHJ X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] On Mon, Aug 4, 2025 at 4:55=E2=80=AFPM Jessica Clarke = wrote: > > CAUTION: This email originated from outside of the University of Guelph. = Do not click links or open attachments unless you recognize the sender and = know the content is safe. If in doubt, forward suspicious emails to IThelp@= uoguelph.ca. > > On 5 Aug 2025, at 00:39, Rick Macklem wrote: > > > The branch main has been updated by rmacklem: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D51affb7e97161e260f6d99cb= 0904daf7cc9f51a7 > > > > commit 51affb7e97161e260f6d99cb0904daf7cc9f51a7 > > Author: Rick Macklem > > AuthorDate: 2025-08-04 23:36:28 +0000 > > Commit: Rick Macklem > > CommitDate: 2025-08-04 23:36:28 +0000 > > > > nfscl: Fix GetACL so that it does not want a reply cached > > > > Without this patch, an NFSv4.1/4.2 GetACL RPC requests that > > the session cache the reply. In some cases, the reply may > > be too large to cache, resulting in a NFS4ERR_X > > error from the server. > > > > Since a GetACL is idempotent, disable reply caching for it, > > by setting that it can generate a large reply. > > Tested against a Linux server with a large ACL on a file. > > > > MFC after: 2 weeks > > --- > > sys/fs/nfs/nfs_commonsubs.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/sys/fs/nfs/nfs_commonsubs.c b/sys/fs/nfs/nfs_commonsubs.c > > index 4ffc4ce5c29f..67e33193ecec 100644 > > --- a/sys/fs/nfs/nfs_commonsubs.c > > +++ b/sys/fs/nfs/nfs_commonsubs.c > > @@ -218,7 +218,7 @@ NFSD_VNET_DEFINE_STATIC(u_char *, nfsrv_dnsname) = =3D NULL; > > */ > > static int nfs_bigreply[NFSV42_NPROCS] =3D { 0, 0, 0, 1, 0, 1, 1, 0, 0,= 0, 0, > > 0, 0, 0, 0, 0, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0= , 0, 0, > > - 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, = 0, 0, 0, > > + 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, = 0, 0, 0, > > 1, 0, 0, 1, 0, 0, 0, 0, 0, 0 }; > > This would be much more readable and maintainable as a C99 designated > initialiser. You are more than welcome to patch it. (Some of this code is decades old and I am just trying to keep up with keeping it working for things like the MIT Kerberos transition. See D51731 as an example.) I could probably think of many nice cleanups, but I am one retired guy who does this as a hobby (not paid any $$ by anyone to do it). rick > > Jess > > > /* local functions */ >