Date: Mon, 4 Jun 2018 17:55:52 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r471272 - head/Mk/Scripts Message-ID: <20180604155552.nyruiecglgcqvfwv@ogg.in.absolight.net> In-Reply-To: <20180604101817.GA43725@FreeBSD.org> References: <201806011620.w51GKmJu004402@repo.freebsd.org> <20180604101817.GA43725@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--ko6tvfytqdwyc2xg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 04, 2018 at 10:18:17AM +0000, Alexey Dokuchaev wrote: > On Fri, Jun 01, 2018 at 04:20:48PM +0000, Mathieu Arnold wrote: > > New Revision: 471272 > > URL: https://svnweb.freebsd.org/changeset/ports/471272 > >=20 > > Log: > > SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. > > =20 > > cd can fail for a variety of reasons: misspelled paths, missing > > directories, missing permissions, broken symlinks and more. >=20 > That's why I'd typically use 'set -e' as a safety net in case I forgot > to handle some command's failure. Yes, note it is only in qa.sh that this was needed, because it is the only one without `set -e`. From what I remember, using it was not possible, I do not remember the details though. Feel free to audit the script to figure out if it is still the case. --=20 Mathieu Arnold --ko6tvfytqdwyc2xg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAABCgBmBQJbFWEIXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85I8m8QAJ2FxQvAzTVmco5BqZ/v6ZFo 0ngHkfON44C/b+FvWsdUdPCINXGbnMDFGZMj1bxVuFkdYr15NvFmomMCF0uawQBZ oShIzOjry7RTMLmfHPSy3XbpRr9gnUHiUUxb3JrfL+diIQYZAds98r4R5V8KK3XX gArdOVqsdEM0f6zkuvscKDl70D5CDiadQzMq8thyIlplGpN2t+46Nbog3Sr2Jnpl AO1x0Hxi6Af6a8ZBtD1DZ1brPz4eVNdXXyqGMnez2xNKa/SqQC+hZyfUqXQ1aGsf jce2ZA5pFHxutNwCWl//SRE0f40s36L4STmQ7aMnDcz6pLe4I7feOcYO1UphwHBz e64ZVKANsM2Z9B42xmmBxZwi+yAf0gWig88KKH8nJL1FkdoU1yD2rX4lzBXqHc89 g9Y3Vow1gIIF242JtaHmPwg0EDSmh7zqtNAgsCgP+4fndcSyuVHNT+mESBwtiWIH SETBw9Rp0Ax7hSy0ajXZDrAeRlRqUl4p+2vJ9IId+RqDCkw5x8T09fLOhODG/VAm gFaN7JDdVDUOSPZt6WPqBZarTaWEX5unXJAIUBzmcFfi1/uO6JUgRZcjViUl4h3I 01L7G87XCVEDM71xQHU+U/bZLrOFoRJErv91nWzNOCnYuxlAYAouE0iOUhrtBjxy WNg9yvzihkUXf89shpog =lo2k -----END PGP SIGNATURE----- --ko6tvfytqdwyc2xg--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180604155552.nyruiecglgcqvfwv>