From owner-cvs-src@FreeBSD.ORG  Fri May 16 02:40:48 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3B4FE37B401; Fri, 16 May 2003 02:40:48 -0700 (PDT)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 573FC43FB1; Fri, 16 May 2003 02:40:46 -0700 (PDT)
	(envelope-from bde@zeta.org.au)
Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246])
	by mailman.zeta.org.au (8.9.3p2/8.8.7) with ESMTP id TAA23963;
	Fri, 16 May 2003 19:40:41 +1000
Date: Fri, 16 May 2003 19:40:40 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: John Baldwin <jhb@FreeBSD.org>
In-Reply-To: <XFMail.20030515160450.jhb@FreeBSD.org>
Message-ID: <20030516192737.E11918@gamplex.bde.org>
References: <XFMail.20030515160450.jhb@FreeBSD.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: Kimura Fuyuki <fuyuki@hadaly.org>
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/alpha/alpha machdep.c src/sys/alpha/osf1
 osf1_signal.c src/sys/amd64/amd64 machdep.c src/sys/compat/linprocfs
 linprocfs.c src/sys/compat/svr4 svr4_filio.c svr4_misc.c src/sys/i
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 16 May 2003 09:40:48 -0000

On Thu, 15 May 2003, John Baldwin wrote:

> On 15-May-2003 Bruce Evans wrote:
> > On Wed, 14 May 2003, John Baldwin wrote:
> >
> >> On 14-May-2003 Kimura Fuyuki wrote:
> >> > At Tue, 13 May 2003 13:36:02 -0700 (PDT),
> >> > John Baldwin <jhb@freebsd.org> wrote:
> >> >>   1.61      +23 -4     src/sys/sys/signalvar.h
> >> >
> >> > There seems to be missing #include <sys/queue.h>.
> >>
> >> Yes. :(  I wonder if it shouldn't be in sys/_lock.h
> >> instead.
> >
> > Less than it should include <sys/types.h> for its use of u_int (i.e.,
> > it shouldn't).
>
> Hmm, I can fix it to use unsigned instead if that is preferred:

There's not much point, since other typedefs are needed (e.g., uintptr_t
in <sys/_mutex.h>.  Also, `unsigned' is messes up the formatting in
<sys/_lock.h>.  The rule for when to use u_int vs. `unsigned' is more or
less "always use u_int" in kernel only [parts of] headers; never use it
in application headers".

Bruce