From owner-cvs-all@FreeBSD.ORG Thu Jul 21 05:34:35 2011 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id C25AC106566B; Thu, 21 Jul 2011 05:34:35 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 65-241-43-4.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 9370914D9A0; Thu, 21 Jul 2011 05:34:16 +0000 (UTC) Message-ID: <4E27BA55.6090005@FreeBSD.org> Date: Wed, 20 Jul 2011 22:34:13 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:5.0) Gecko/20110706 Thunderbird/5.0 MIME-Version: 1.0 To: Olli Hauer References: <201107192245.p6JMjR57018930@repoman.freebsd.org> In-Reply-To: <201107192245.p6JMjR57018930@repoman.freebsd.org> X-Enigmail-Version: 1.2pre OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, jhelfman@experts-exchange.com, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/www/tomcat55 Makefile ports/www/tomcat55/files logprocessor-cronolog tomcat55.sh.in X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jul 2011 05:34:35 -0000 This rc.d script still has a lot of problems. The biggest being that it runs a lot of code in the body of the script, which we like to avoid doing. I started to take a crack at it, but there are more things here that need attention than I have time for. All of the stuff that updates the environment needs to be in a function. Assuming that they are only needed at start time, a prestart function should do the trick. If they are needed for start and stop then name it something like tomcat_env() and call it in both places. I'm not sure where to start on the pidfile stuff, since it's not clear to me what's being attempted. It should likely be isolated into a start_precmd. Rather than using cd directly in the script as it does in the second to last line, look at ${name}_chdir from rc.subr. If you need help with this stuff, feel free to follow up to freebsd-rc@. hth, Doug On 07/19/2011 15:45, Olli Hauer wrote: > ohauer 2011-07-19 22:45:27 UTC > > FreeBSD ports repository > > Modified files: > www/tomcat55 Makefile > www/tomcat55/files tomcat55.sh.in > Removed files: > www/tomcat55/files logprocessor-cronolog > Log: > - fix cronolog processing option [1] > - improve pidfile handling in rc script [2] > > PR: ports/158237 [1], ports/158410 [2] http://www.FreeBSD.org/cgi/query-pr.cgi?pr=158237 > Submitted by: Jason Helfman (maintainer) [1] > Phil Phillips [2] > Approved by: maintainer > > Revision Changes Path > 1.59 +7 -15 ports/www/tomcat55/Makefile > 1.2 +0 -74 ports/www/tomcat55/files/logprocessor-cronolog (dead) > 1.11 +8 -19 ports/www/tomcat55/files/tomcat55.sh.in > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/tomcat55/Makefile.diff?&r1=1.58&r2=1.59&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/tomcat55/files/logprocessor-cronolog > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/tomcat55/files/tomcat55.sh.in.diff?&r1=1.10&r2=1.11&f=h > -- Nothin' ever doesn't change, but nothin' changes much. -- OK Go Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/