Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 3 Sep 2019 07:47:40 -0400
From:      Shawn Webb <shawn.webb@hardenedbsd.org>
To:        Brooks Davis <brooks@freebsd.org>
Cc:        Mateusz Guzik <mjg@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r351729 - in head: lib/libc/gen lib/libc/sys sys/compat/freebsd32 sys/kern sys/sys
Message-ID:  <20190903114740.gbzkeffdce3mkee2@mutt-hbsd>
In-Reply-To: <20190903114523.GA68094@spindle.one-eyed-alien.net>
References:  <201909030416.x834GVwk004191@repo.freebsd.org> <20190903113505.ckbx5i34onmin557@mutt-hbsd> <20190903114523.GA68094@spindle.one-eyed-alien.net>

next in thread | previous in thread | raw e-mail | index | archive | help

--jopdem4ihmaajanv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Sep 03, 2019 at 11:45:23AM +0000, Brooks Davis wrote:
> On Tue, Sep 03, 2019 at 07:35:05AM -0400, Shawn Webb wrote:
> > Hey Mateusz,
> >=20
> > On Tue, Sep 03, 2019 at 04:16:31AM +0000, Mateusz Guzik wrote:
> > > Author: mjg
> > > Date: Tue Sep  3 04:16:30 2019
> > > New Revision: 351729
> > > URL: https://svnweb.freebsd.org/changeset/base/351729
> > >=20
> > > Log:
> > >   Add sysctlbyname system call
> > >  =20
> > >   Previously userspace would issue one syscall to resolve the sysctl =
and then
> > >   another one to actually use it. Do it all in one trip.
> > >  =20
> > >   Fallback is provided in case newer libc happens to be running on an=
 older
> > >   kernel.
> > >  =20
> > >   Submitted by:	Pawel Biernacki
> > >   Reported by:	kib, brooks
> > >   Differential Revision:	https://reviews.freebsd.org/D17282
> > >=20
> > > Modified:
> > ... snip ...
> > >   head/sys/sys/param.h
> >=20
> > ... snip ...
> >=20
> > >=20
> > > Modified: head/sys/sys/param.h
> > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> > > --- head/sys/sys/param.h	Mon Sep  2 21:57:57 2019	(r351728)
> > > +++ head/sys/sys/param.h	Tue Sep  3 04:16:30 2019	(r351729)
> > > @@ -60,7 +60,7 @@
> > >   *		in the range 5 to 9.
> > >   */
> > >  #undef __FreeBSD_version
> > > -#define __FreeBSD_version 1300044	/* Master, propagated to newvers */
> > > +#define __FreeBSD_version 1300045	/* Master, propagated to newvers */
> >=20
> > To an outsider, it seems that __FreeBSD_version tends to be bumped in
> > a separate commit. Am I remembering that right?
>=20
> It should be bumped in the same commit, but people forget or the bump
> they have in their review turns into a no-op because someone else does a
> bump in the interim (the latter has bit me several times).

Interesting. Thanks for the clarification!

--=20
Shawn Webb
Cofounder / Security Engineer
HardenedBSD

Tor-ified Signal:    +1 443-546-8752
Tor+XMPP+OTR:        lattera@is.a.hacker.sx
GPG Key ID:          0xFF2E67A277F8E1FA
GPG Key Fingerprint: D206 BB45 15E0 9C49 0CF9  3633 C85B 0AF8 AB23 0FB2

--jopdem4ihmaajanv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAl1uUtYACgkQ/y5nonf4
4frNJQ/+M8/K5K8o4Z4Xp1KL3op8NO0VFweAF8M2SV8cRkSRFceI/Hs8E2umwtv3
p2lK6nzFwF4aW/Kt5G/uNtnIiL+IRoXtXzFBNjHEvTkL8i/mqQ3CX6Fs4AILyXQ8
GqzO4fnM49Yz1ibLymbMyslMS+KDmY8qJiHOyVf+LvJhQuN03Xm3UHqx/AuzIZ58
O0149gLa9GLlZ0J2/CWEQiOAxhHIkI2zCq542CIghk3Djkclt4nHfwLhbWz5KOGh
slN2kRFkfm98Y35mVL434TzarkLGdLGfZYTlu8UWe9j6ffZg+M3Npax9w6acfFn2
k+1TFjyjeyX4qbB4ZlTT7yud5fDrpIAEJ8lmqoAoSl5jWqkv/szkzSMUVXBEo0hu
4CAA9pXuWPnpIkoJvnUfucYuNuXhfqAz3q0A6d14aD1DP3k61n1+s64vx2Rhgy2o
8HReJyt/4g0iG8JM6Y+bPjp9v2FV1ruyhI7jipdQSuFjAgTBaN+lkq6OvH9JM9QB
mATHmVXJP+MZdW3kA9TC7Z16JHjwTK4EJJYIpf5PvY0UmNsf7y1q0CuX8sX3jTyr
owN5lTK6hdnbF/6PQRlONYSvjG6Roz+4K3ZSTD5YA090QGPwhQnJhMo8GnJAjN6X
0ZjFj7yI+KhTIzEqMxh4uDKoOiAhADbRL6mVKrpiNwSHB/4tQBc=
=reGw
-----END PGP SIGNATURE-----

--jopdem4ihmaajanv--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190903114740.gbzkeffdce3mkee2>