From owner-svn-src-all@FreeBSD.ORG  Tue Dec 30 22:12:47 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id C8500187;
 Tue, 30 Dec 2014 22:12:47 +0000 (UTC)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 5096F1075;
 Tue, 30 Dec 2014 22:12:46 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id sBUMCiAc036085
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Wed, 31 Dec 2014 01:12:44 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id sBUMCh6U036084;
 Wed, 31 Dec 2014 01:12:43 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Wed, 31 Dec 2014 01:12:43 +0300
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Mateusz Guzik <mjguzik@gmail.com>
Subject: Re: svn commit: r276341 - head/sys/kern
Message-ID: <20141230221243.GH15484@FreeBSD.org>
References: <201412281924.sBSJO284028980@svn.freebsd.org>
 <20141230200601.GF15484@FreeBSD.org>
 <20141230202226.GA27329@dft-labs.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20141230202226.GA27329@dft-labs.eu>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Dec 2014 22:12:47 -0000

On Tue, Dec 30, 2014 at 09:22:27PM +0100, Mateusz Guzik wrote:
M> On Tue, Dec 30, 2014 at 11:06:01PM +0300, Gleb Smirnoff wrote:
M> > On Sun, Dec 28, 2014 at 07:24:02PM +0000, Mateusz Guzik wrote:
M> > M> Author: mjg
M> > M> Date: Sun Dec 28 19:24:01 2014
M> > M> New Revision: 276341
M> > M> URL: https://svnweb.freebsd.org/changeset/base/276341
M> > M> 
M> > M> Log:
M> > M>   sysctl: don't modify oid_running for static nodes
M> > M>   
M> > M>   It is necessary to prevent nodes from being destroyed while used, but static
M> > M>   ones cannot be destroyed.
M> > 
M> > What about nodes that go away on kernel module unload? Not sure
M> > they were protected properly before your commit, though :)
M> > 
M> 
M> They are not static.

I don't see how they can get CTLFLAG_DYN. Look for any (un)loadable
modules as an example, e.g. aio(4) implemented in vfs_aio.c. How its
sysctls get CTLFLAG_DYN?

-- 
Totus tuus, Glebius.