From owner-freebsd-wireless@FreeBSD.ORG Sat Nov 17 03:41:01 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 01EE8C4E for ; Sat, 17 Nov 2012 03:41:00 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id C41458FC16 for ; Sat, 17 Nov 2012 03:41:00 +0000 (UTC) Received: by mail-pb0-f54.google.com with SMTP id wz12so2495626pbc.13 for ; Fri, 16 Nov 2012 19:40:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type; bh=tKbjVUjc6H6js9lMWz6u06N8TbveS+esEHJvB2zU3Yc=; b=QC6VQ69Wkz8cQhcLH82hj+IajnEJuHdWYBYphUQ2WGagrvBRVZOmLJcd0YR6akn8qh qKxVVxjOcF5Rsz0Z9OPibvlQZ95TPuPAFNWHW8WRusDHRFQ02ez4aMNk8doHzIbV8nGO jxyQH/R2SV+cv/nB3AcDN3e+gjVa6DimT2lvmWg+SH3J+9mqXwyWn1RvCKYF9hrnwle1 C+pXeSAPHiaV6vGHqd5djp9UkSam46C4VYLzn3A4KHFDbSDuARy4u9KeKVAyhnPuWz7w SBWeHjJ7mvEHsNyQD9o6L5mZbzAC2Fybbxttp0DBfV9ddJS3XUQt9Wn+h6PLRwUCv0R3 FrIA== MIME-Version: 1.0 Received: by 10.66.89.9 with SMTP id bk9mr18253668pab.67.1353123654501; Fri, 16 Nov 2012 19:40:54 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.68.124.130 with HTTP; Fri, 16 Nov 2012 19:40:54 -0800 (PST) In-Reply-To: <201211170239.qAH2dc42007560@svn.freebsd.org> References: <201211170239.qAH2dc42007560@svn.freebsd.org> Date: Fri, 16 Nov 2012 19:40:54 -0800 X-Google-Sender-Auth: 1j9M-QQnCtRjt5HbEdJzS8Ey0aA Message-ID: Subject: Fwd: svn commit: r243174 - head/sys/dev/ath/ath_hal/ar5210 From: Adrian Chadd To: freebsd-wireless@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Nov 2012 03:41:01 -0000 For like, the two of you out there who still have an AR5210 of some sort, please try this out. This seems to work correctly and correctly populate the RTS duration field. Adrian ---------- Forwarded message ---------- From: Adrian Chadd Date: 16 November 2012 18:39 Subject: svn commit: r243174 - head/sys/dev/ath/ath_hal/ar5210 To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Author: adrian Date: Sat Nov 17 02:39:37 2012 New Revision: 243174 URL: http://svnweb.freebsd.org/changeset/base/243174 Log: Correctly populate the RTS field. Tested: * AR5210, STA mode, RTS enabled Modified: head/sys/dev/ath/ath_hal/ar5210/ar5210_xmit.c Modified: head/sys/dev/ath/ath_hal/ar5210/ar5210_xmit.c ============================================================================== --- head/sys/dev/ath/ath_hal/ar5210/ar5210_xmit.c Sat Nov 17 02:39:09 2012 (r243173) +++ head/sys/dev/ath/ath_hal/ar5210/ar5210_xmit.c Sat Nov 17 02:39:37 2012 (r243174) @@ -518,7 +518,8 @@ ar5210SetupTxDesc(struct ath_hal *ah, st ads->ds_ctl1 = 0; if (flags & HAL_TXDESC_RTSENA) { ads->ds_ctl0 |= AR_RTSCTSEnable; - ads->ds_ctl1 |= rtsctsDuration & AR_RTSDuration; + ads->ds_ctl1 |= (rtsctsDuration << AR_RTSDuration_S) + & AR_RTSDuration; } return AH_TRUE; }