From owner-cvs-src@FreeBSD.ORG Thu Mar 9 18:57:23 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from green.homeunix.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 04F1E16A420; Thu, 9 Mar 2006 18:57:22 +0000 (GMT) (envelope-from green@green.homeunix.org) Received: from green.homeunix.org (green@localhost [127.0.0.1]) by green.homeunix.org (8.13.4/8.13.1) with ESMTP id k29IvMfn066023; Thu, 9 Mar 2006 13:57:22 -0500 (EST) (envelope-from green@green.homeunix.org) Received: (from green@localhost) by green.homeunix.org (8.13.4/8.13.1/Submit) id k29IvLkL066022; Thu, 9 Mar 2006 13:57:21 -0500 (EST) (envelope-from green) Date: Thu, 9 Mar 2006 13:57:21 -0500 From: Brian Fundakowski Feldman To: Pawel Jakub Dawidek Message-ID: <20060309185721.GE7835@green.homeunix.org> References: <200602221021.k1MAL5qF031937@repoman.freebsd.org> <20060307003911.GB7835@green.homeunix.org> <20060307133200.GA60850@garage.freebsd.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060307133200.GA60850@garage.freebsd.pl> User-Agent: Mutt/1.5.11 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/geom/raid3 g_raid3.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Mar 2006 18:57:23 -0000 On Tue, Mar 07, 2006 at 02:32:00PM +0100, Pawel Jakub Dawidek wrote: > On Mon, Mar 06, 2006 at 07:39:11PM -0500, Brian Fundakowski Feldman wrote: > +> On Wed, Feb 22, 2006 at 10:21:05AM +0000, Pawel Jakub Dawidek wrote: > +> > pjd 2006-02-22 10:21:05 UTC > +> > > +> > FreeBSD src repository > +> > > +> > Modified files: > +> > sys/geom/raid3 g_raid3.c > +> > Log: > +> > Do not use bio structure after g_io_deliver(), it may not longer by valid. > +> > > +> > Found and fixed by: Vsevolod Lobko > +> > MFC after: 3 days > +> > +> I actually found and fixed it half a year ago... could you please > +> integrate the rest of the fixes from my changes back then? A > +> short-term low-memory deadlock is still possible (observed in > +> practice). I think the changes also improve readability -- see > +> for example the reason r1.46 existed. > > Heh. I own you apology. I haven't had time to work on graid3 back then > and I also overlooked fix of this very problem. > > I integrated you fixes to my last patch which I'm planning to commit > after receiving some feedback: > > http://people.freebsd.org/~pjd/patches/graid3.patch Everything seems good to go, running -CURRENT's graid3 + these changes on 6-STABLE; are there particular areas where you think I should try testing for improved performance? -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\