From owner-cvs-src@FreeBSD.ORG Sat Aug 30 00:42:50 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ECC9916A4C0 for ; Sat, 30 Aug 2003 00:42:50 -0700 (PDT) Received: from relay.pair.com (relay.pair.com [209.68.1.20]) by mx1.FreeBSD.org (Postfix) with SMTP id 62B6344003 for ; Sat, 30 Aug 2003 00:42:48 -0700 (PDT) (envelope-from silby@silby.com) Received: (qmail 15349 invoked from network); 30 Aug 2003 07:42:47 -0000 Received: from niwun.pair.com (HELO localhost) (209.68.2.70) by relay.pair.com with SMTP; 30 Aug 2003 07:42:47 -0000 X-pair-Authenticated: 209.68.2.70 Date: Sat, 30 Aug 2003 02:41:45 -0500 (CDT) From: Mike Silbersack To: Robert Watson In-Reply-To: <200308291912.h7TJCIfP047192@repoman.freebsd.org> Message-ID: <20030830023923.Q811@odysseus.silby.com> References: <200308291912.h7TJCIfP047192@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_ethersubr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Aug 2003 07:42:51 -0000 On Fri, 29 Aug 2003, Robert Watson wrote: > rwatson 2003/08/29 12:12:18 PDT > > FreeBSD src repository > > Modified files: > sys/net if_ethersubr.c > Log: > Introduce error checking for calls to M_PREPEND(): > > ether_output() when prepending netatalk AFA_PHASE2 llc headers (TRYWAIT). > ether_output() when prepending ethernet header to a frame (DONTWAIT). I may have mentioned this before, but it would really useful to have code which we could easily paste where needed that would do a "fail once per caller". This would be much more useful than random failures in detecting callers that don't check return values because it would ensure that each case was hit, whereas random failures only offer a statistical chance that it will happen after a sufficiently long period of time. I'm envisioning something which keeps a linked list of caller addresses... horribly inefficient, but useable enough to be hidden being a FAILURE_STRESS_TEST option. Mike "Silby" Silbersack