From owner-freebsd-arch@FreeBSD.ORG Fri Feb 25 21:04:32 2005 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 37AD716A4CE; Fri, 25 Feb 2005 21:04:32 +0000 (GMT) Received: from spiff.melthusia.org (spiff.melthusia.org [207.67.244.17]) by mx1.FreeBSD.org (Postfix) with ESMTP id CFC5D43D1F; Fri, 25 Feb 2005 21:04:31 +0000 (GMT) (envelope-from gordon@tetlows.org) Received: from [64.37.153.164] (ip-153-164.station.sony.com [64.37.153.164]) (authenticated bits=0) by spiff.melthusia.org (8.12.10/8.12.10) with ESMTP id j1PL49uO065253; Fri, 25 Feb 2005 13:04:12 -0800 (PST) (envelope-from gordon@tetlows.org) Message-ID: <421F92BC.3030904@tetlows.org> Date: Fri, 25 Feb 2005 13:03:56 -0800 From: Gordon Tetlow User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Garance A Drosihn References: <200410020349.i923nG8v021675@northstar.hetzel.org> <20041002052856.GE17792@nexus.dglawrence.com> <20041002233542.GL714@nexus.dglawrence.com> In-Reply-To: X-Enigmail-Version: 0.90.1.1 X-Enigmail-Supports: pgp-inline, pgp-mime X-Habeas-SWE-1: winter into spring X-Habeas-SWE-2: brightly anticipated X-Habeas-SWE-3: like Habeas SWE (tm) X-Habeas-SWE-4: Copyright 2002 Habeas (tm) X-Habeas-SWE-5: Sender Warranted Email (SWE) (tm). The sender of this X-Habeas-SWE-6: email in exchange for a license for this Habeas X-Habeas-SWE-7: warrant mark warrants that this is a Habeas Compliant X-Habeas-SWE-8: Message (HCM) and not spam. Please report use of this X-Habeas-SWE-9: mark in spam to http://www.habeas.com/report/. Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig67D23C2E3443A407BBB95CCA" cc: Maxim Sobolev cc: "David G. Lawrence" cc: freebsd-arch@freebsd.org Subject: Re: Bug in #! processing - One More Time X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Feb 2005 21:04:32 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig67D23C2E3443A407BBB95CCA Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Garance A Drosihn wrote: > As I see it, we have the following choices to fix this: > > 1) MFC the January 31st change to kern/imgact_shell.c to 5.3-stable, > as it is. This means we haven't fixed the problem that people > complained about in 2002 and again in 2004. And I still think > it is "not appropriate" for the execve() system to be deciding > what '#' means on that line. The biggest advantage is that this > means 5.4-release will behave exactly the same as 3.5 through > 5.3-release have behaved. > > 2) Remove '#'-processing from kern/imgact_shell.c, and remove my > change to bin/sh/options.c (which doesn't work right once we > do that). This breaks shell-scripts which use the feature as > documented by perl (and other scripting languages), and fixes > the problem people complained about in 2002/2004. > > 3) Change kern/imgact_shell.c to process shebang options the same > way other (non-BSD?) operating systems do. By that I mean: > send the entire string as arg[1], and let the scripting > language sort it out. This is an incompatible change from > FreeBSD 5.3 to 5.4, but would put make us "more consistent" > with other operating systems. > > 4) Provide some way for /bin/sh to find out where the shebang > options end, and the user-specified options begin. This could > make everyone happy, but it's more work and right now (this > close to 5.4-release) that wouldn't make me particularly happy... > > Or we could do #1 for now, and plan to do #4 after 5.4-release. > Or do #1 now in 5.3, and go with some incompatible change (#2 > or #3) only in 6.x-current. I would say we should stick with #1 for the 5.x release and use #3 for 6.x and further. We have already frozen APIs and ABIs. For people that might have scripts that use this syntax to have problems between minor releases is unacceptable. -gordon --------------enig67D23C2E3443A407BBB95CCA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (MingW32) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCH5LDRu2t9DV9ZfsRAowrAJ9QzrezkSYlktdWKjXburHbhYCK2QCglbDF D7f3gXXqoeFSGWdKhxVnKgg= =AxjF -----END PGP SIGNATURE----- --------------enig67D23C2E3443A407BBB95CCA--