From nobody Tue Feb 3 17:34:40 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f59bP1ZbYz6QT5Q for ; Tue, 03 Feb 2026 17:34:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f59bN6Sthz3M32 for ; Tue, 03 Feb 2026 17:34:40 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770140080; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zA9HmhStF1TNmjvJ45eCgPwjBjRNkXDFa2itdL/WayY=; b=JWV5eaOyK8G3JFjfdnOoqFqdwkkG/JZYo+A25jLIrK4PLL5ctGcLaP16a+bMP5+2qzs1Gy ANJjmXghlE4psxkii9LqF3BWhXe+P/iCGTEI0XFd8QeTt9cVuddSuSEezymhBM+INAY1BU HtsdrjKnk1ApuZu5uTqNDXO1QuQlgVrq2oBZdOhGTh9jSMIb3W2k9gBbVSueXMmhS4wFaI P5zaHfpYh4TKKiuC/muI9y7I0AD35vTYzhkliNe0ujS6r48I5vpwzCM/bDJrpQhY9k5oZ6 cCd8m+BJKTP00bsjT9H6EwZR9WaOD1C4O0jnJvXdYgfBYRmUnUftoSPkhiMF0w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770140080; a=rsa-sha256; cv=none; b=Lu50yeIrjFicOcdjZt8rfF8c2woqhHqvOtxP/rnabkpp/9o+QYuUz1va7sRXZ+Ku41mjKW 5AVZyxa7QDzlH7IluBExGSVC7QpvW5+KrQm7+h57NtFgBNQjW4PYHNMAC2TUOQ6QKxbqCw nkwFxi1j6/FsLuBVkZFxxJiW2bUy1eMfVKoONYRBb4g0xym7rEStPqCehzBMbn/ImBiy/e 2ioqFN4uH9MFKBf5i7EXzFLvLgat0LkJaqYt0eQK1Vbv0fJPRKXVzX/+yDOksx40wuufp3 5d/StJJCUfmXZG92WCla+ARpS7gB6Sa8N5Ct0Y2QVRPQMFnb1KEfshwjJFKFzw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770140080; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zA9HmhStF1TNmjvJ45eCgPwjBjRNkXDFa2itdL/WayY=; b=l84D65XneaJceLry0XBg9FCIGt11DqJwWAcjLgravWA6T9PE1zLlJT0oxZ2jj5tbjvD10x EoCC35BdZ/sYk+AmYihp+oHQSwgwplwvYHVFQRdrwT0+LKQ4tE+imw0zOkwpkFAmrycqjg 12/eAftKbOxSXGnthtKekpBjpe2AWQG3wkoI5+1EMR5m+Bt66IYJSOJFgBeBs3lcIMIRSA uXtIBlIk4K14HIwyyJ4xFH903iuKVT2tzU248HbYWP1nSgY6B3Q5Ls/YwKrmP+nhiI/lmy DN7eoXtC7pzAvOhc4aD9nik9qrt1PJXBupx0eVdjvgnxtqR7ULtwXqikIU5IAQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f59bN5kWtz7C4 for ; Tue, 03 Feb 2026 17:34:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1f940 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 03 Feb 2026 17:34:40 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: cbb7441245cf - main - nvmecontrol: Pass 1 to uint8_t arg List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: cbb7441245cf2b22efed17dec3c88587c980c691 Auto-Submitted: auto-generated Date: Tue, 03 Feb 2026 17:34:40 +0000 Message-Id: <698231b0.1f940.26da653a@gitrepo.freebsd.org> The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=cbb7441245cf2b22efed17dec3c88587c980c691 commit cbb7441245cf2b22efed17dec3c88587c980c691 Author: Warner Losh AuthorDate: 2026-02-03 17:34:36 +0000 Commit: Warner Losh CommitDate: 2026-02-03 17:34:36 +0000 nvmecontrol: Pass 1 to uint8_t arg The rae arg is uint8_t (which we then shift over to the right bit. Pass '1' instead of 'true' here to match the interface. While true is promoted to (uint8_t)1, we don't use it as a bool in read_logpage(). Fixes: 5322eec86ae4 ("nvmecontrol: Always set the RAE bit on telemetry-log requests") Sponsored by: Netflix Reviewed by: chs Differential Revision: https://reviews.freebsd.org/D55060 --- sbin/nvmecontrol/telemetry.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sbin/nvmecontrol/telemetry.c b/sbin/nvmecontrol/telemetry.c index 60bd3e025f3d..2561d7dff20d 100644 --- a/sbin/nvmecontrol/telemetry.c +++ b/sbin/nvmecontrol/telemetry.c @@ -139,7 +139,7 @@ telemetry_log(const struct cmd *f, int argc, char *argv[]) /* Read the log page */ size = sizeof(tlp); off = 0; - read_logpage(fd, NVME_LOG_TELEMETRY_HOST_INITIATED, nsid, 0, 0, true, + read_logpage(fd, NVME_LOG_TELEMETRY_HOST_INITIATED, nsid, 0, 0, 1, off, 0, 0, 0, &tlp, size); switch(opt.da) { case 1: @@ -171,7 +171,7 @@ telemetry_log(const struct cmd *f, int argc, char *argv[]) (unsigned long long)blocks); fflush(stdout); } - read_logpage(fd, NVME_LOG_TELEMETRY_HOST_INITIATED, nsid, 0, 0, true, + read_logpage(fd, NVME_LOG_TELEMETRY_HOST_INITIATED, nsid, 0, 0, 1, off, 0, 0, 0, &buf, chunk); if (write(fdout, &buf, chunk) != chunk) err(EX_IOERR, "Error writing %s", opt.outfn);