From owner-cvs-all Mon Oct 21 7: 9:30 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 76AE737B401; Mon, 21 Oct 2002 07:09:29 -0700 (PDT) Received: from espresso.q9media.com (espresso.q9media.com [65.39.129.122]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1FC7F43E6A; Mon, 21 Oct 2002 07:09:29 -0700 (PDT) (envelope-from mike@espresso.q9media.com) Received: by espresso.q9media.com (Postfix, from userid 1002) id 39FA39BC3; Mon, 21 Oct 2002 10:01:36 -0400 (EDT) Date: Mon, 21 Oct 2002 10:01:36 -0400 From: Mike Barcroft To: Poul-Henning Kamp Cc: Bruce Evans , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/isa npx.c Message-ID: <20021021100136.B80691@espresso.q9media.com> References: <20021021093912.A80691@espresso.q9media.com> <2283.1035208541@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2283.1035208541@critter.freebsd.dk>; from phk@critter.freebsd.dk on Mon, Oct 21, 2002 at 03:55:41PM +0200 Organization: The FreeBSD Project Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Poul-Henning Kamp writes: > In message <20021021093912.A80691@espresso.q9media.com>, Mike Barcroft writes: > > >Can your lint define a constant that is in the implementation > >namespace (eg. _LINT)? This would at least improve your change to > >i386's which breaks things if an application > >happens to `#define lint' in a C90 environment. > > Ohh, absolutely, that would be no problem at all. > > The problem is that "lint" is our standard for this: > > bang# sh /root/gsys lint | grep '#' | grep -v compile | wc -l > 299 > bang# sh /root/gsrc lint | grep '#' | grep -v compile | wc -l > 5558 > > I'm not particularly attached to "lint", it can be any symbol we > decide on, as long as we use the same one all over... Yes, but this is the second time ever "lint" has been used in a standard header or in a header a standard header includes. The first was in about a month ago, but since it only modifies macros in the implementation namespace it isn't a problem. It might be a wise idea to do a mass rename (similar to the KERNEL to _KERNEL mass rename of 1999). Best regards, Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message