From owner-freebsd-bugs Sat Apr 7 4:24:28 2001 Delivered-To: freebsd-bugs@freebsd.org Received: from Awfulhak.org (awfulhak.demon.co.uk [194.222.196.252]) by hub.freebsd.org (Postfix) with ESMTP id 0556C37B424; Sat, 7 Apr 2001 04:24:25 -0700 (PDT) (envelope-from brian@Awfulhak.org) Received: from hak.lan.Awfulhak.org (root@hak.lan.Awfulhak.org [172.16.0.12]) by Awfulhak.org (8.11.3/8.11.3) with ESMTP id f37BOQU25082; Sat, 7 Apr 2001 12:24:26 +0100 (BST) (envelope-from brian@lan.Awfulhak.org) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.11.3/8.11.3) with ESMTP id f37BOEl55762; Sat, 7 Apr 2001 12:24:14 +0100 (BST) (envelope-from brian@hak.lan.Awfulhak.org) Message-Id: <200104071124.f37BOEl55762@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.3.1 01/18/2001 with nmh-1.0.4 To: Bruce Evans Cc: freebsd-bugs@FreeBSD.org, brian@Awfulhak.org, mckusick@FreeBSD.org Subject: Re: bin/26057: [PATCH] Minor ps(1) fixes In-Reply-To: Message from Bruce Evans of "Sat, 07 Apr 2001 01:20:03 PDT." <200104070820.f378K3R53066@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sat, 07 Apr 2001 12:24:14 +0100 From: Brian Somers Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org > > ps.c part committed by brian (1.37 of bin/ps/ps.c). I'll update the > > man page later today. > > The committed fix is half-baked at best. It does't even remove the > session keyword like the first version of the PR does. > > Kirk also removed the tsess pointer and keyword from everywhere except > ps.1, but the PR doesn't mention it. The log message for rev.1.25 of > keyword.c says the following about the removal: > > kernel/user interface, specifically rusage and rtprio. It no > longer contains proc, session, pcred, ucred, procsig, vmspace, > pstats, mtx, sigiolst, klist, callout, pasleep, or mdproc. If > any of these changed in size, ps, w, fstat, gcore, systat, and > top would all stop working. The new structure has over 200 bytes > > This is incorrect for "session" in ps at least. ps would not have > stopped working if sizeof(struct session) changed, since it just > printed the session pointer. I've now updated the documentation. Do you and Kirk agree that sess and tsess should come back ? > Bruce -- Brian Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message