From nobody Wed Aug 20 18:11:29 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c6ZJx6qvgz64mnK; Wed, 20 Aug 2025 18:11:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c6ZJx61ygz4MMK; Wed, 20 Aug 2025 18:11:29 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755713489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=98toItlmW1yzmE4VPoh6lSalhCb6yCb7ETi2oTB2K8E=; b=Ksb8SAZAUYQYYNa5LioBnOBCXhoQrzWqniT0wD71AV0mJrFlktbcCfSE/ZK2HUryXr3tEF eRkhoE0DLu1Y3lnoHnjLdYq2ltr9H9lTfZ3TVes6gFZ7FQ5nXRCyofSvA2x2yZJnqQA2cD IVZDtttF0fVqmAP1IxQc/+wLXvtl6FO+X2/SJVtUeqGra+2aLRcFIvNzgad9l6OBYu5io0 PH20j/M0IwgoZ4vTsVZzNoAh2WCLMcI2F8LTmzzDyICNBOCaxCZUqJTWuGMVFNu4CQUuvd K6ZjBTVbaIQ0gDwwsPxqyHTXX27+9huv8b7zfcNefGAY54txcahyBRZ5Pc+IVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755713489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=98toItlmW1yzmE4VPoh6lSalhCb6yCb7ETi2oTB2K8E=; b=N7eSiQC5oz+Vk9AVvtfS6yChH7Pq4jbA6D3YmiSs4iFChrwI+lkyQLBMDe7ZiZsuxMPt73 I9ETlcdOm6bev7XAntCLdSqm+F+9fj9AZpNvYnTDHxzL2c2ESmh12ancOYo09eQKbNR1mU 3Zrr1LXvdyWn6OwZVVKs2amsw3NctUaTlSZ3rtMObpuSwB1VPxHGlG42Tykv807DDfH+U8 a1WoRBrk3oIwhbbvoKQLzIgawLV3HXfb0t+Yb/uHsGa5N8aMJlQiiJFQXE6wTXlYSoGJrn rVAVV7276ZGnCeuZCNrJ8076BsfLLM3cjyuzbGHfrwbt1ceuzKvuGBKsZFiKyw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1755713489; a=rsa-sha256; cv=none; b=aJdMUhkG7yJbaBJCTpZ4YkirmC2dykT11vw97dMOklYfBNyuTN/98WyiX8iLNMzhysDCN/ cWMvP3DGL8jo84dcGgZh7B3tbE911c0NLcNQRT6dWmzunI3NcsWJmma5GYI6kQjo0ZP3xl fuoYaLTiGIugnkFQYPew7QXwFlOg9342WH2PaB+/0J4ibQUNODyD0fyww0qkXZJJt7lNYp qfTHWgi5kO06hC1kKphgV+CO/hW/ez/N2TkNhO2J63N8Jk7pkfWhhNJhfuNWl8kz+sgYP9 uQmfdeyXkb8z8Zyu7lwEcsxHFIyR99AEy25EqyJb8cOU9sHJMKpiOR8dyiVgkQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4c6ZJx5W19z83T; Wed, 20 Aug 2025 18:11:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 57KIBTPi002330; Wed, 20 Aug 2025 18:11:29 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 57KIBTT5002327; Wed, 20 Aug 2025 18:11:29 GMT (envelope-from git) Date: Wed, 20 Aug 2025 18:11:29 GMT Message-Id: <202508201811.57KIBTT5002327@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mitchell Horne Subject: git: c0771d8c78b4 - main - jh7110_pcie.c: add empty PIC methods to conform conventions List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mhorne X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c0771d8c78b421b26c9b32a899f8d0131bb46ef4 Auto-Submitted: auto-generated The branch main has been updated by mhorne: URL: https://cgit.FreeBSD.org/src/commit/?id=c0771d8c78b421b26c9b32a899f8d0131bb46ef4 commit c0771d8c78b421b26c9b32a899f8d0131bb46ef4 Author: Jari Sihvola AuthorDate: 2025-08-20 17:13:00 +0000 Commit: Mitchell Horne CommitDate: 2025-08-20 18:09:37 +0000 jh7110_pcie.c: add empty PIC methods to conform conventions This commit updates the driver code to conform with an undocumented convention which says that certain functions need always be implemented together regardless of their content (or lack of). It's been said that unimplemented KOBJ methods become stubs which return ENXIO so this commit does not imply a functional change. Reviewed by: mhorne Differential Revision: https://reviews.freebsd.org/D52042 --- sys/riscv/starfive/jh7110_pcie.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/sys/riscv/starfive/jh7110_pcie.c b/sys/riscv/starfive/jh7110_pcie.c index 2d0a4be69b2c..5181252ab2dc 100644 --- a/sys/riscv/starfive/jh7110_pcie.c +++ b/sys/riscv/starfive/jh7110_pcie.c @@ -482,6 +482,16 @@ jh7110_pcie_msi_enable_intr(device_t dev, struct intr_irqsrc *isrc) jh7110_pcie_msi_mask(dev, isrc, false); } +static void +jh7110_pcie_msi_post_filter(device_t dev, struct intr_irqsrc *isrc) +{ +} + +static void +jh7110_pcie_msi_post_ithread(device_t dev, struct intr_irqsrc *isrc) +{ +} + static void jh7110_pcie_msi_pre_ithread(device_t dev, struct intr_irqsrc *isrc) { @@ -1008,6 +1018,8 @@ static device_method_t jh7110_pcie_methods[] = { /* Interrupt controller interface */ DEVMETHOD(pic_enable_intr, jh7110_pcie_msi_enable_intr), DEVMETHOD(pic_disable_intr, jh7110_pcie_msi_disable_intr), + DEVMETHOD(pic_post_filter, jh7110_pcie_msi_post_filter), + DEVMETHOD(pic_post_ithread, jh7110_pcie_msi_post_ithread), DEVMETHOD(pic_pre_ithread, jh7110_pcie_msi_pre_ithread), /* OFW bus interface */