Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 29 Dec 2013 09:25:47 GMT
From:      Yamagi Burmeister <yamagi@yamagi.org>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/185262: [PATCH] Fix audio/ncmpcpp on 10.0 and add stagedir support
Message-ID:  <201312290925.rBT9Plu5066316@oldred.freebsd.org>
Resent-Message-ID: <201312290930.rBT9U0dp016571@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         185262
>Category:       ports
>Synopsis:       [PATCH] Fix audio/ncmpcpp on 10.0 and add stagedir support
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Dec 29 09:30:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Yamagi Burmeister
>Release:        FreeBSD 10.0-RC3
>Organization:
>Environment:
FreeBSD happy.home.yamagi.org 10.0-RC3 FreeBSD 10.0-RC3 #0 r259944M: Sun Dec 29 00:58:05 CET 2013     root@happy.home.yamagi.org:/usr/obj/usr/src/sys/HAPPY  amd64
>Description:
Clang is currently unable to build audio/ncmpcpp due to hundreds of type missmatches between ncurses and the local C++ code. I don't think that this can be resolved by a patch of reasonable length. Therefor force the usage of g++ by adding USE_GCC=any to the port. While at it add stagedir support.
>How-To-Repeat:

>Fix:
Index: Makefile
===================================================================
--- Makefile	(Revision 337842)
+++ Makefile	(Arbeitskopie)
@@ -15,8 +15,8 @@
 		libfftw3.so:${PORTSDIR}/math/fftw3
 
 USES=		iconv ncurses pkgconfig
-NO_STAGE=	yes
 USE_BZIP2=	yes
+USE_GCC=	any
 GNU_CONFIGURE=	yes
 USE_GNOME=	glib20
 USE_AUTOTOOLS=	automake aclocal libtool
@@ -90,15 +90,15 @@
 .endif
 
 post-install:
-	${INSTALL_PROGRAM} ${WRKSRC}/src/ncmpcpp ${PREFIX}/bin/
+	${INSTALL_PROGRAM} ${WRKSRC}/src/ncmpcpp ${STAGEDIR}${PREFIX}/bin/
 .if ${PORT_OPTIONS:MDOCS}
-	@${ECHO_MSG} "installing additional documentation to ${DOCSDIR}"
+	@${ECHO_MSG} "installing additional documentation to ${STAGEDIR}${DOCSDIR}"
 	@${MKDIR} ${DOCSDIR}
-	${INSTALL_DATA} ${WRKSRC}/NEWS ${DOCSDIR}/NEWS
-	${INSTALL_DATA} ${WRKSRC}/AUTHORS ${DOCSDIR}/AUTHORS
-	${INSTALL_DATA} ${WRKSRC}/COPYING ${DOCSDIR}/COPYING
-	${INSTALL_DATA} ${WRKSRC}/doc/config ${DOCSDIR}/config
-	${INSTALL_DATA} ${WRKSRC}/doc/keys ${DOCSDIR}/keys
+	${INSTALL_DATA} ${WRKSRC}/NEWS ${STAGEDIR}${DOCSDIR}/NEWS
+	${INSTALL_DATA} ${WRKSRC}/AUTHORS ${STAGEDIR}${DOCSDIR}/AUTHORS
+	${INSTALL_DATA} ${WRKSRC}/COPYING ${STAGEDIR}${DOCSDIR}/COPYING
+	${INSTALL_DATA} ${WRKSRC}/doc/config ${STAGEDIR}${DOCSDIR}/config
+	${INSTALL_DATA} ${WRKSRC}/doc/keys ${STAGEDIR}${DOCSDIR}/keys
 .endif
 
 	@${ECHO_MSG} "" 

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201312290925.rBT9Plu5066316>