From owner-svn-src-head@FreeBSD.ORG Wed Feb 25 22:17:18 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1033) id C4F36E61; Wed, 25 Feb 2015 22:17:18 +0000 (UTC) Date: Wed, 25 Feb 2015 22:17:18 +0000 From: Alexey Dokuchaev To: Ed Maste Subject: Re: svn commit: r278914 - in head/sys: kern sys Message-ID: <20150225221718.GA70971@FreeBSD.org> References: <201502171932.t1HJWCWk092408@svn.freebsd.org> <20150225134004.GA84927@FreeBSD.org> <5199092.b33a1iaAip@ralph.baldwin.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Cc: "src-committers@freebsd.org" , John Baldwin , Rui Paulo , "svn-src-all@freebsd.org" , Gleb Smirnoff , "svn-src-head@freebsd.org" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Feb 2015 22:17:18 -0000 On Wed, Feb 25, 2015 at 05:04:07PM -0500, Ed Maste wrote: > On 25 February 2015 at 14:47, John Baldwin wrote: > > On Wednesday, February 25, 2015 01:40:04 PM Alexey Dokuchaev wrote: > >> > >> In r278673 I used full URL to D1801, but it was not closed for some > >> reason. Could it be that rS (src repository) entries auto-closed when > >> committed by src-folks only? > > > > It seems like it might not close a differential that hasn't been accepted > > yet [...] That would make sense, but I've certainly had committed proposed patch after D1801 was accepted (twice). > I think this is an intermittent failure in Phabricator. I expect it to > close upon commit regardless of the state of the review. Assuming (for now) that it is some weird failure, I've manually closed D1801 and provided correct auto-close-like message (citing SVN revision and author links). On a related note: while searching for proper auto-close message, I've found that many differentials are closed without marking SVN revision as such, so it does not link to it directly. This is not nice; we should make sure that these "dots are connected". ./danfe