From owner-svn-src-all@FreeBSD.ORG Mon Feb 6 15:40:56 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E22A41065676; Mon, 6 Feb 2012 15:40:56 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from agogare.doit.wisc.edu (agogare.doit.wisc.edu [144.92.197.211]) by mx1.freebsd.org (Postfix) with ESMTP id B357E8FC1C; Mon, 6 Feb 2012 15:40:56 +0000 (UTC) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII; format=flowed Received: from avs-daemon.smtpauth2.wiscmail.wisc.edu by smtpauth2.wiscmail.wisc.edu (Sun Java(tm) System Messaging Server 7u2-7.05 32bit (built Jul 30 2009)) id <0LYZ00800A889Y00@smtpauth2.wiscmail.wisc.edu>; Mon, 06 Feb 2012 09:40:56 -0600 (CST) Received: from comporellon.tachypleus.net (adsl-76-208-68-223.dsl.mdsnwi.sbcglobal.net [76.208.68.223]) by smtpauth2.wiscmail.wisc.edu (Sun Java(tm) System Messaging Server 7u2-7.05 32bit (built Jul 30 2009)) with ESMTPSA id <0LYZ007C7A862J00@smtpauth2.wiscmail.wisc.edu>; Mon, 06 Feb 2012 09:40:55 -0600 (CST) Date: Mon, 06 Feb 2012 09:40:54 -0600 From: Nathan Whitehorn In-reply-to: <201202060753.43627.jhb@freebsd.org> To: John Baldwin Message-id: <4F2FF486.5090507@freebsd.org> X-Spam-Report: AuthenticatedSender=yes, SenderIP=76.208.68.223 X-Spam-PmxInfo: Server=avs-13, Version=5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.2.6.153022, SenderIP=76.208.68.223 References: <201202051654.q15GsQcc092137@svn.freebsd.org> <201202060753.43627.jhb@freebsd.org> User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120107 Thunderbird/9.0 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r231026 - head/sys/powerpc/ofw X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Feb 2012 15:40:57 -0000 On 02/06/12 06:53, John Baldwin wrote: > On Sunday, February 05, 2012 11:54:26 am Nathan Whitehorn wrote: >> Author: nwhitehorn >> Date: Sun Feb 5 16:54:26 2012 >> New Revision: 231026 >> URL: http://svn.freebsd.org/changeset/base/231026 >> >> Log: >> Make sure to remap adjusted resources. > Hmm, I had considered remapping adjusted resources an invalid operation (i.e. > should fail with EINVAL). I believe that the NEW_PCIB code should only apply > this API to resources backing the resource windows in PCI-PCI bridges and that > those resources should never have RF_ACTIVE set. Are you seeing calls of it > for active resources? > No, I was just trying to be safe here, since it wasn't clear that that was invalid. I'm happy to replace the contents of the if with return EINVAL or something. -Nathan