From owner-freebsd-bugs Wed Jan 9 12:20:35 2002 Delivered-To: freebsd-bugs@freebsd.org Received: from mail5.speakeasy.net (mail5.speakeasy.net [216.254.0.205]) by hub.freebsd.org (Postfix) with ESMTP id A4DEE37B428 for ; Wed, 9 Jan 2002 12:20:10 -0800 (PST) Received: (qmail 20563 invoked from network); 9 Jan 2002 20:20:10 -0000 Received: from unknown (HELO server.baldwin.cx) ([64.81.54.73]) (envelope-sender ) by mail5.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 9 Jan 2002 20:20:10 -0000 Received: from laptop.baldwin.cx (root@laptop.baldwin.cx [192.168.0.4]) by server.baldwin.cx (8.11.6/8.11.6) with ESMTP id g09KKAK58399; Wed, 9 Jan 2002 12:20:10 -0800 (PST) (envelope-from john@laptop.baldwin.cx) Received: (from john@localhost) by laptop.baldwin.cx (8.11.6/8.11.6) id g09KJav06174; Wed, 9 Jan 2002 12:19:36 -0800 (PST) (envelope-from john) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200201091433.g09EXdc01274@freefall.freebsd.org> Date: Wed, 09 Jan 2002 12:19:36 -0800 (PST) From: John Baldwin To: sheldonh@FreeBSD.org Subject: Re: kern/33124: kthread_create doesnt mark kthreads as kthreads. Cc: freebsd-bugs@FreeBSD.org, Anders Nor Berle Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On 09-Jan-02 sheldonh@FreeBSD.org wrote: > Synopsis: kthread_create doesnt mark kthreads as kthreads. > > Responsible-Changed-From-To: freebsd-bugs->jhb > Responsible-Changed-By: sheldonh > Responsible-Changed-When: Wed Jan 9 06:30:03 PST 2002 > Responsible-Changed-Why: > John has already made a similar change in HEAD, but the change doesn't > seem to have been merged onto RELENG_4. > > http://www.FreeBSD.org/cgi/query-pr.cgi?pr=33124 This is actually kind of bogus. Nobody uses this flag except aio, and aio just sets the flag, no code actually checks it. P_KTHREAD is a new flag in -current used in a few places. Unless the submitter has code that actually checks P_KTHREADP and needs it set for some reason, I would rather see the flag killed. One thing that might be nice to MFC is changing aio to use kthread_create rather than using its own home-rolled version. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message