From owner-svn-src-head@FreeBSD.ORG Thu Dec 11 19:03:20 2008 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 84931106564A; Thu, 11 Dec 2008 19:03:20 +0000 (UTC) (envelope-from gonzo@bluezbox.com) Received: from core.tav.kiev.ua (tavex.colocall.com [62.149.10.42]) by mx1.freebsd.org (Postfix) with ESMTP id 3BCA88FC14; Thu, 11 Dec 2008 19:03:19 +0000 (UTC) (envelope-from gonzo@bluezbox.com) Received: from 204-174-83-31.static569.dsl.ucc-net.ca ([204.174.83.31] helo=[10.80.5.156]) by core.tav.kiev.ua with esmtpsa (SSLv3:AES256-SHA:256) (Exim 4.52 (FreeBSD)) id 1LAqLj-000Es7-9n; Thu, 11 Dec 2008 20:33:25 +0200 Message-ID: <49415CD4.7090904@bluezbox.com> Date: Thu, 11 Dec 2008 10:32:52 -0800 From: Oleksandr Tymoshenko User-Agent: Thunderbird 2.0.0.18 (Windows/20081105) MIME-Version: 1.0 To: =?UTF-8?B?RGFnLUVybGluZyBTbcO4cmdyYXY=?= References: <200812110822.mBB8MKLd059320@svn.freebsd.org> <86oczjklk8.fsf@ds4.des.no> In-Reply-To: <86oczjklk8.fsf@ds4.des.no> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Core-Spam-Level: ---- X-Core-Spam-Report: Spam detection software, running on the system "core.tav.kiev.ua", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Dag-Erling Smørgrav wrote: > Warner Losh writes: >> Author: imp >> Date: Thu Dec 11 08:22:20 2008 >> New Revision: 185925 >> URL: http://svn.freebsd.org/changeset/base/185925 >> >> Log: >> Push mips support into the tree. > > Just to pick a random mips commit - > > There is something wrong with the mips toolchain. The build breaks in > libpam, while building the static version, which includes all modules: > > ../modules/pam_deny/libpam_deny.a(pam_deny.o)(.text+0x3c): In function `pam_sm_open_session': > /src/lib/libpam/modules/pam_deny/pam_deny.c:80: multiple definition of `pam_sm_open_session' > ../modules/pam_chroot/libpam_chroot.a(pam_chroot.o)(.text+0x14):/src/lib/libpam/modules/pam_chroot/pam_chroot.c:54: first defined here > [lather, rinse, repeat for every service function in every module] > > The service functions should be static. The logic PAM uses to determine > whether it is building static or shared modules is as follows: > > #if defined(__GNUC__) && !defined(__PIC__) && !defined(NO_STATIC_MODULES) Using ABI calls (-mabicalls) assume -fPIC. This issue is known for a long time now and I proposed a fix but didn't have enough time to get/commit proper solution. We discussed it about three months ago: http://lists.freebsd.org/pipermail/freebsd-arch/2008-August/008430.html [...] Content analysis details: (-4.4 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.8 ALL_TRUSTED Passed through trusted hosts only via SMTP -2.6 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Warner Losh Subject: Re: svn commit: r185925 - in head/contrib/binutils: bfd gas/config ld/emulparams X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Dec 2008 19:03:20 -0000 Dag-Erling Smørgrav wrote: > Warner Losh writes: >> Author: imp >> Date: Thu Dec 11 08:22:20 2008 >> New Revision: 185925 >> URL: http://svn.freebsd.org/changeset/base/185925 >> >> Log: >> Push mips support into the tree. > > Just to pick a random mips commit - > > There is something wrong with the mips toolchain. The build breaks in > libpam, while building the static version, which includes all modules: > > ../modules/pam_deny/libpam_deny.a(pam_deny.o)(.text+0x3c): In function `pam_sm_open_session': > /src/lib/libpam/modules/pam_deny/pam_deny.c:80: multiple definition of `pam_sm_open_session' > ../modules/pam_chroot/libpam_chroot.a(pam_chroot.o)(.text+0x14):/src/lib/libpam/modules/pam_chroot/pam_chroot.c:54: first defined here > [lather, rinse, repeat for every service function in every module] > > The service functions should be static. The logic PAM uses to determine > whether it is building static or shared modules is as follows: > > #if defined(__GNUC__) && !defined(__PIC__) && !defined(NO_STATIC_MODULES) Using ABI calls (-mabicalls) assume -fPIC. This issue is known for a long time now and I proposed a fix but didn't have enough time to get/commit proper solution. We discussed it about three months ago: http://lists.freebsd.org/pipermail/freebsd-arch/2008-August/008430.html