From owner-freebsd-hackers@FreeBSD.ORG  Sun Nov  5 21:36:11 2006
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
X-Original-To: freebsd-hackers@freebsd.org
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id DCA1D16A40F;
	Sun,  5 Nov 2006 21:36:11 +0000 (UTC)
	(envelope-from tataz@tataz.chchile.org)
Received: from smtp4-g19.free.fr (smtp4-g19.free.fr [212.27.42.30])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 84D7B43D6D;
	Sun,  5 Nov 2006 21:36:02 +0000 (GMT)
	(envelope-from tataz@tataz.chchile.org)
Received: from tatooine.tataz.chchile.org (tataz.chchile.org [82.233.239.98])
	by smtp4-g19.free.fr (Postfix) with ESMTP id 5739F88EA;
	Sun,  5 Nov 2006 22:36:02 +0100 (CET)
Received: from obiwan.tataz.chchile.org (unknown [192.168.1.25])
	by tatooine.tataz.chchile.org (Postfix) with ESMTP id 4CE609E6C2;
	Sun,  5 Nov 2006 21:36:40 +0000 (UTC)
Received: by obiwan.tataz.chchile.org (Postfix, from userid 1000)
	id 2A880405B; Sun,  5 Nov 2006 22:36:40 +0100 (CET)
Date: Sun, 5 Nov 2006 22:36:40 +0100
From: Jeremie Le Hen <jeremie@le-hen.org>
To: Ruslan Ermilov <ru@freebsd.org>
Message-ID: <20061105213640.GZ20405@obiwan.tataz.chchile.org>
References: <20061105200447.GY20405@obiwan.tataz.chchile.org>
	<20061105211413.GA72777@rambler-co.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20061105211413.GA72777@rambler-co.ru>
User-Agent: Mutt/1.5.13 (2006-08-11)
Cc: freebsd-hackers@freebsd.org, Jeremie Le Hen <jeremie@le-hen.org>
Subject: Re: [fbsd] Re: Puzzling variables behaviour in make(1)
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 05 Nov 2006 21:36:12 -0000

Hi Ruslan,

thank you for your swiftness.

On Mon, Nov 06, 2006 at 12:14:13AM +0300, Ruslan Ermilov wrote:
> Command-line variables are of the highest precedence.
> 
> %%%
> Index: parse.c
> ===================================================================
> RCS file: /home/ncvs/src/usr.bin/make/parse.c,v
> retrieving revision 1.111
> diff -u -p -r1.111 parse.c
> --- parse.c	22 Jul 2006 14:00:31 -0000	1.111
> +++ parse.c	5 Nov 2006 21:09:51 -0000
> @@ -2231,7 +2231,7 @@ parse_message(char *line, int iserror, i
>  	while (isspace((u_char)*line))
>  		line++;
>  
> -	line = Buf_Peel(Var_Subst(line, VAR_GLOBAL, FALSE));
> +	line = Buf_Peel(Var_Subst(line, VAR_CMD, FALSE));
>  	Parse_Error(iserror ? PARSE_FATAL : PARSE_WARNING, "%s", line);
>  	free(line);
>  
> %%%

The patch works.

Regards,
-- 
Jeremie Le Hen
< jeremie at le-hen dot org >< ttz at chchile dot org >