From owner-svn-src-projects@FreeBSD.ORG Tue Nov 3 06:42:56 2009 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 116811065672; Tue, 3 Nov 2009 06:42:56 +0000 (UTC) (envelope-from gonzo@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 017318FC30; Tue, 3 Nov 2009 06:42:56 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id nA36gtD2082377; Tue, 3 Nov 2009 06:42:55 GMT (envelope-from gonzo@svn.freebsd.org) Received: (from gonzo@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id nA36gtVx082375; Tue, 3 Nov 2009 06:42:55 GMT (envelope-from gonzo@svn.freebsd.org) Message-Id: <200911030642.nA36gtVx082375@svn.freebsd.org> From: Oleksandr Tymoshenko Date: Tue, 3 Nov 2009 06:42:55 +0000 (UTC) To: src-committers@freebsd.org, svn-src-projects@freebsd.org X-SVN-Group: projects MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r198842 - projects/mips/sys/mips/mips X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Nov 2009 06:42:56 -0000 Author: gonzo Date: Tue Nov 3 06:42:55 2009 New Revision: 198842 URL: http://svn.freebsd.org/changeset/base/198842 Log: - Handle errors when adding children to nexus. This sittuation might occure when there is dublicate of child's entry in hints Modified: projects/mips/sys/mips/mips/nexus.c Modified: projects/mips/sys/mips/mips/nexus.c ============================================================================== --- projects/mips/sys/mips/mips/nexus.c Tue Nov 3 05:53:48 2009 (r198841) +++ projects/mips/sys/mips/mips/nexus.c Tue Nov 3 06:42:55 2009 (r198842) @@ -257,6 +257,8 @@ nexus_hinted_child(device_t bus, const c int mem_hints_count; child = BUS_ADD_CHILD(bus, 0, dname, dunit); + if (child == NULL) + return; /* * Set hard-wired resources for hinted child using @@ -306,6 +308,10 @@ nexus_add_child(device_t bus, int order, resource_list_init(&ndev->nx_resources); child = device_add_child_ordered(bus, order, name, unit); + if (child == NULL) { + device_printf(bus, "failed to add child: %s%d\n", name, unit); + return (0); + } /* should we free this in nexus_child_detached? */ device_set_ivars(child, ndev);