From nobody Wed Aug 16 18:37:22 2023 X-Original-To: ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RQxh51vz0z4r0LC for ; Wed, 16 Aug 2023 18:37:25 +0000 (UTC) (envelope-from felix@palmen-it.de) Received: from stef.palmen-it.de (stef.palmen-it.de [IPv6:2001:470:1f0b:bbb:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4RQxh401pcz3CVj for ; Wed, 16 Aug 2023 18:37:23 +0000 (UTC) (envelope-from felix@palmen-it.de) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=palmen-it.de header.s=20200414 header.b=XWn3SQRm; spf=pass (mx1.freebsd.org: domain of felix@palmen-it.de designates 2001:470:1f0b:bbb:1::1 as permitted sender) smtp.mailfrom=felix@palmen-it.de; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=palmen-it.de; s=20200414; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:To:From:Date:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=iquYX9FDyF3HBZTR2rUKcALZWyYofRz7X5i5EswrTFo=; b=XWn3SQRmwS4hG8YbAcnrTdlMr+ mQWM511vX6GRTwKHGflI1BXnyn/ZJVnaQdL89NeLRKmuWM7HBj7t3RSK/I4T1gE4rwkP8f+ambzBd 1nS7CMlHgWg4UlWQrAefzlvgL28xiVULUjWSzb39CB8EdxUmp52fnVLu1Z1qgoG8KhMDT6c0IeJjw kZKlLgKY2pOpLK6brai13DcErMc2QzfjLkXSKHEMnCTWboHlHyOlhdZgzqDG1Oez6DsX91rBLjde5 Syp7PcGuaakaAiITcnPdNpMr1uObbVPRva1jJ6Gf+M8Lx3VsEjJdGrGLlxDeV4aZZwo749uhJzFZS TmH6luKw==; Received: from [192.168.71.101] (helo=mail.home.palmen-it.de) by stef.palmen-it.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qWLOU-009vtU-Px for ports@freebsd.org; Wed, 16 Aug 2023 20:37:22 +0200 Received: from nexus.home.palmen-it.de ([192.168.99.2]) by mail.home.palmen-it.de with esmtpsa (TLS1.3) tls TLS_CHACHA20_POLY1305_SHA256 (Exim 4.96 (FreeBSD)) (envelope-from ) id 1qWLOU-000J39-1n for ports@freebsd.org; Wed, 16 Aug 2023 18:37:22 +0000 Date: Wed, 16 Aug 2023 20:37:22 +0200 From: Felix Palmen To: ports@freebsd.org Subject: Re: plist-check not reporting orphaned files present in a @comment Message-ID: <67hyj5pbnd2hf66tdj2szrtyhxozmjjcevw5rooas2vzrltxna@oqjzi7m5tfho> Mail-Followup-To: ports@freebsd.org X-Face: /1K@t"h.}e~pR@]c7HorQ!T`F^RJCa'BCr#e>IKA{>C/9OTGB4|xh"y2{?1Z5M i2w"AH^pN_LlHR^{+f',_Np~;.B;!M/bL}*qk]p5*r7F5vW};{:@4u5S?T&f0$7BJ-71Q5SV]:v$`5 A0[DZ:=?S52x8HJ~5@^P_\T@MsjG{R( Organization: FreeBSD.org References: <5h3c6jbzs7y5k3hyimqn7jkyo3se3txvcywahpcffzc24hjew7@kx4mhnqq7gh4> <8raa-vofq-wny@FreeBSD.org> <2ppfted4t72jo2bhgxfmoghpm6zukhrcqevucxvouqqwehwugg@zy4chydjtuxy> List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="thzncskf3s5zvj2r" Content-Disposition: inline In-Reply-To: <2ppfted4t72jo2bhgxfmoghpm6zukhrcqevucxvouqqwehwugg@zy4chydjtuxy> User-Agent: NeoMutt/20230517 X-Spamd-Result: default: False [-7.49 / 15.00]; SIGNED_PGP(-2.00)[]; DWL_DNSWL_MED(-2.00)[palmen-it.de:dkim]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.99)[-0.994]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_DKIM_ARC_DNSWL_MED(-0.50)[]; FORGED_SENDER(0.30)[zirias@freebsd.org,felix@palmen-it.de]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; R_SPF_ALLOW(-0.20)[+ip6:2001:470:1f0b:bbb:1::1:c]; RCVD_IN_DNSWL_MED(-0.20)[2001:470:1f0b:bbb:1::1:from]; R_DKIM_ALLOW(-0.20)[palmen-it.de:s=20200414]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; DMARC_NA(0.00)[freebsd.org]; MLMMJ_DEST(0.00)[ports@freebsd.org]; FROM_HAS_DN(0.00)[]; TO_DOM_EQ_FROM_DOM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; HAS_ORG_HEADER(0.00)[]; TO_DN_NONE(0.00)[]; ARC_NA(0.00)[]; DKIM_TRACE(0.00)[palmen-it.de:+]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FROM_NEQ_ENVFROM(0.00)[zirias@freebsd.org,felix@palmen-it.de]; RCVD_TLS_ALL(0.00)[] X-Spamd-Bar: ------- X-Rspamd-Queue-Id: 4RQxh401pcz3CVj --thzncskf3s5zvj2r Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable * Felix Palmen [20230816 20:26]: > * Jan Beich [20230816 20:20]: > > Looks intentional per https://cgit.freebsd.org/ports/commit/?id=3De1544= 9a9eff5 > >=20 > > > - Fix showing files installed through unselected OPTIONS as orphan= s, > > > by considering "@comment file" to be ignored. [2] > > [...] > > > [2] This is a partial solution, we may still need a plist.ignore too.= It > > > doesn't make much sense to add files in main pkg-plist we don't c= are about, > > > but maybe it does since you'll see and reconsider them being igno= red > > > someday. @comment is used as all the OPTION PLIST_SUB deactivatio= ns use > > > @comment instead of something like @ignore. >=20 > [...] > Yes, this is at best a partial solution. It's probably fine for options > cause there's always the case that something *is* built/installed by the > upstream build system and you still don't want to package it. It really > breaks things for my current use case though. > [...] On a second thought, doesn't it acually break more than it solves? Sure, you *could* think about some explicit '@ignore' alongside '@comment' with different semantics, but, isn't it more or less a corner case that you don't want to package some files (based on port options) but can't prevent the upstream build system from putting them in ${STAGEDIR}? IMHO, the straight-forward solution would be: A port hit by that should add some "post-install-" (or -off) recipe explicitly removing the unwanted files from ${STAGEDIR}. --=20 Felix Palmen {private} felix@palmen-it.de -- ports committer -- {web} http://palmen-it.de {pgp public key} http://palmen-it.de/pub.txt {pgp fingerprint} 6936 13D5 5BBF 4837 B212 3ACC 54AD E006 9879 F231 --thzncskf3s5zvj2r Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iNUEABYKAH0WIQRpNhPVW79IN7ISOsxUreAGmHnyMQUCZN0XYl8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0Njkz NjEzRDU1QkJGNDgzN0IyMTIzQUNDNTRBREUwMDY5ODc5RjIzMQAKCRBUreAGmHny MW3dAP4jXEQhAmg/oRLCFyeTjMFU5qKqlNDF59X7xcsKBsHwXAEAhBKGYAQR5oNt MRn0GSkgrr28oC9YOb35AKXErCZHjAM= =b2k1 -----END PGP SIGNATURE----- --thzncskf3s5zvj2r--