From owner-cvs-src@FreeBSD.ORG Sat Aug 23 03:32:28 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 018B6106564A; Sat, 23 Aug 2008 03:32:28 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 763088FC1D; Sat, 23 Aug 2008 03:32:27 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from zion.baldwin.cx (zion.baldwin.cx [IPv6:2001:470:1f11:75:2a0:d2ff:fe18:8b38]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m7N3WFuv010991; Fri, 22 Aug 2008 23:32:21 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Craig Rodrigues Date: Fri, 22 Aug 2008 22:45:50 -0400 User-Agent: KMail/1.9.7 References: <200808230121.m7N1LM79093524@repoman.freebsd.org> In-Reply-To: <200808230121.m7N1LM79093524@repoman.freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200808222245.50842.jhb@freebsd.org> Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [IPv6:2001:470:1f11:75::1]); Fri, 22 Aug 2008 23:32:21 -0400 (EDT) X-Virus-Scanned: ClamAV 0.93.1/8076/Fri Aug 22 18:15:54 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=AWL,BAYES_00,NO_RELAYS autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sbin/fsck_ffs main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Aug 2008 03:32:28 -0000 On Friday 22 August 2008 09:21:10 pm Craig Rodrigues wrote: > rodrigc 2008-08-23 01:21:10 UTC > > FreeBSD src repository > > Modified files: > sbin/fsck_ffs main.c > Log: > SVN rev 182027 on 2008-08-23 01:21:10Z by rodrigc > > Instead of passing MNT_UPDATE, MNT_SNAPSHOT, MNT_RELOAD from > userspace to kernel via nmount(), pass in the strings > "update", "snapshot", "reload". > > We want to move away from passing MNT_ flags from userspace -> kernel > via nmount(), and instead favor passing the string options. > > Revision Changes Path > 1.53 +3 -2 src/sbin/fsck_ffs/main.c Hmm, one thing that I've mentioned to you before though is that some options (like update) aren't mount options, they are flags to the mount() syscall that explain how to apply the list of options. Those sort of flags don't really belong in the mount options list it seems to be, but in a separate "flags" argument to nmount() itself. That would also remove the need for having the kernel weed out these options (force/update/etc.) from the mount options list by not having them there in the first place. I think having mount operation flags passed separately from mount options is going to be a less bug-prone and more stable approach. -- John Baldwin