From owner-svn-src-all@freebsd.org Tue Jan 15 20:20:28 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5F5D1149500A for ; Tue, 15 Jan 2019 20:20:28 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1.eu.mailhop.org (outbound1.eu.mailhop.org [52.28.251.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C22576F83E for ; Tue, 15 Jan 2019 20:20:27 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1547583619; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=G4VotBFlglDMG+RuU9SnaO+qztkJkMmymUnez8wo2BO3LTdwm3WKSk1xYTTdI10X3EkPunWZEfBc6 0AY8mCUNOjnjGj97WA+kUT5GvsTEdFJJF+BcItc6J7zP8XEW/FYbdzg94Jc2s0hN4eQaJE8pF+HVLw +hcp7GbJTpa+QGDoGLAcMhYXHt9bk17vjTlb97AMshfynscH62KyRzIcseuG3d4JNJ69eGKUmV1Nfg RCIpYNeWD1/DhKfSAg2sLKaizK19fTBJ5EPJ5pxfP+n+nbTciPthRD99XghbsHFo2yHj7muTdCJcnD p9m/jC51nOKNE3mOsXF30Tomo68d33Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=GvdNdrm0KPcCpM2KH7WpCIrKZpr9Ylw+9v02wScWlI8=; b=ArYZ1PJX+a2gCDwVSWlmi7wP8F16/5nW1XcaSUoitqTmlfGnJuLR/mEyXYx/gCV/0+ykc7Efgs1Ss pMBOKfczKy0IF/l8ftRNkhOjUX36N5iDaR6jJjg9bXrzGqtivJdKRp6t/33Ek7G7Sax+E+2HgOdcHB w/Uvf03v5ZdudJ+UcaQg8TBripT46jib/x+h3A3bSx+z3KbQEm6NB3wFG1AF2WpI5P0oUPAE3oolI7 DtZ4tqBykDC0N5grcSqiV7vBgT6UO7kMvB7hI1i2V5qkkLYtL+uIAeQ79sTDawca+ggyAfo8q5ofgl +tm7SMqtQDIe2FDGGx4KF3aR9VOGwxg== ARC-Authentication-Results: i=1; outbound3.eu.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=GvdNdrm0KPcCpM2KH7WpCIrKZpr9Ylw+9v02wScWlI8=; b=Z+FBMr4R1WULJf3IfO8YcAfAGZ9lUEJePfXqhd/rE8QLjUjLzQRLjMsCNOSiAmoKM9NHDxV8QGTtF ZaEGWEL4dnmEDS9MVJqBygv8jC2vygpa315L/MWapJmY2+iVGcYnuVa67SQqLKpa3wyVk2LR59sG6F ahCgn4jQmq0yOGlfrZ1v3cF9r+Ua1jgcQLS7FKSD0bqnW1h5KgoJrrubCTKIpT3atZCURZVHLhYTEj ledgeWUaoQUOiF31vTxk1H642hFPYtjyWvBqyK/dnLICQNcAJv0Au/CgBQwMWX+qAtQ6ueqphW1VFA rHIx86RT4nxLGXNLmk0vrsqC0PK8Tdw== X-MHO-RoutePath: aGlwcGll X-MHO-User: f7e920e5-1902-11e9-8a28-a1efd8da9a94 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.eu.mailhop.org (Halon) with ESMTPSA id f7e920e5-1902-11e9-8a28-a1efd8da9a94; Tue, 15 Jan 2019 20:20:16 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x0FKKEeJ072390; Tue, 15 Jan 2019 13:20:14 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <79ee763bb72a47f3e7888caf266174a62c23e532.camel@freebsd.org> Subject: Re: svn commit: r343058 - in head/sys: compat/linuxkpi/common/src vm From: Ian Lepore To: Gleb Smirnoff , Justin Hibbits Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Tue, 15 Jan 2019 13:20:14 -0700 In-Reply-To: <20190115200617.GZ18452@FreeBSD.org> References: <201901151933.x0FJXl8a069317@repo.freebsd.org> <20190115134623.139064b2@titan.knownspace> <20190115200617.GZ18452@FreeBSD.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C22576F83E X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.985,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jan 2019 20:20:28 -0000 On Tue, 2019-01-15 at 12:06 -0800, Gleb Smirnoff wrote: > On Tue, Jan 15, 2019 at 01:46:23PM -0600, Justin Hibbits wrote: > J> Why not #include counter.h in the relevant vm_machdep.c files > instead? > > This also is ugly :( Not sure more or less. Probably less, but I > urged to plug all possible compilation failures at a time. > > What is ugly is that most files just need counter_u64_t size, > and they don't use counter(9) KPI. > > The fact that vm_machdep or Linux KPI want to look into internal > type uma_zone_t is also ugly. > Isn't the usual fix for this problem to create a __counter_u64_t in sys/types.h and use it in places where including the full header file is undesirable for some reason? -- Ian