From owner-svn-src-head@freebsd.org Wed Apr 5 02:22:00 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EEB7CD2F392; Wed, 5 Apr 2017 02:22:00 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x243.google.com (mail-pf0-x243.google.com [IPv6:2607:f8b0:400e:c00::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C1DB98BC; Wed, 5 Apr 2017 02:22:00 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x243.google.com with SMTP id 197so33078pfv.0; Tue, 04 Apr 2017 19:22:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=wWcZgN0FqYbXKPDyAPFCAbFRvsWZxd7CIa7UUVACan4=; b=KUNxZxTvLXubU9KQp/qwIyfvl7UEz3ZgnqvCu0E3bgMkPaNFEOzZw1d9Rdp9QiEl8H F8iV2C+Ehzt2kzoF4gFE9sRiG0/zpiJhcL13ynxqyGGVGbojHYjMm0sSRDvPvQfJytCy VEqdmAC9vhqT2De7lqEuf/u9bJyILBEhVxkkf6P9ZKc7JS1QltBUz+1RjHD+9CBB9zjo Y+AHojrF7IJ2DGP/tXEatx+jdxsVWnBz1EcoAzM4TkSWXrrcUIpE819/4vf9sQ5koEPz NOVYWK3qC8aarpyoDctlgT56V2aQ1xWw3YXst0wpCwPMVEtSzkkafrtw+JBl2qE+CFpC Thhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=wWcZgN0FqYbXKPDyAPFCAbFRvsWZxd7CIa7UUVACan4=; b=Vni8wscU2YrwEq9kgqxDM+ymSbVs5LO1tpoN9e/iNygigZa92x08FgDK6CM8DSoROX /L4yBD+jta9jPmYSVfTpJg1ItHniF8JdmU+cSIEzfrJ8KkWvUtwf73S/wtH7E1d1ojac bndVkDGEu7gHZDjF1jXZDCW1g0+u0xG5bZVucydERjonAi+jfs/XyL4vrsHRKn4AIjMi GkiY7EHhtBGEcHNTwCkXpDLgV4eKdlWiE8s4K9sZuPW3t2roDnWRpaT/1y1MsXX17kfj dXDBeJO9p15H9ZZu8jVmGGxJ36PEF+yA1nNzyfAv028pGnt9GWKQ7qSA2JrESYqQtIip n1iw== X-Gm-Message-State: AFeK/H2JUsEFqSkeknd24MD6e8wXmnnrqZa/FrxSEp8bUEYSOabtkkJMpcDGdhYegyvwVw== X-Received: by 10.84.178.101 with SMTP id y92mr32925341plb.171.1491358920249; Tue, 04 Apr 2017 19:22:00 -0700 (PDT) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id s27sm33974942pfi.10.2017.04.04.19.21.59 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 04 Apr 2017 19:21:59 -0700 (PDT) Subject: Re: svn commit: r316492 - in head/usr.bin/grep: . regex Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_7A898D46-24EB-4B69-BEA2-EF8E4CCD0680"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <25D20383-8A5B-4F78-B8B4-12F9B3521626@FreeBSD.org> Date: Tue, 4 Apr 2017 19:21:58 -0700 Cc: Kyle Evans , Conrad Meyer , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers , Dimitry Andric Message-Id: <73AAB945-B506-4986-AAF8-A922AF38C496@gmail.com> References: <201704041608.v34G8qSo055328@repo.freebsd.org> <4D675D2F-7D6F-4AF2-AE10-5DF19D4158D0@gmail.com> <2CA2F0F0-17E4-4E9F-BDD6-10EDFECDB679@gmail.com> <25D20383-8A5B-4F78-B8B4-12F9B3521626@FreeBSD.org> To: Pedro Giffuni X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Apr 2017 02:22:01 -0000 --Apple-Mail=_7A898D46-24EB-4B69-BEA2-EF8E4CCD0680 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Apr 4, 2017, at 19:21, Pedro Giffuni wrote: >=20 >> On Apr 4, 2017, at 14:48, Kyle Evans wrote: >>=20 >> On Tue, Apr 4, 2017 at 2:45 PM, Ngie Cooper (yaneurabeya) = wrote: >>=20 >> > On Apr 4, 2017, at 12:04, Conrad Meyer wrote: >> > >> > On Tue, Apr 4, 2017 at 11:56 AM, Dimitry Andric = wrote: >> >> On 4 Apr 2017, at 19:14, Ngie Cooper (yaneurabeya) = wrote: >> >>> Where did xmalloc.c originate from? >> >> >> >> GNU. >> > >> > I believe this to be completely incorrect. >> > >> >> Almost all software from the GNU project relies on malloc wrappers >> >> which abort the program on allocation failures. >> > >> > That is not what bsdgrep's xmalloc() did, if you read the code. It >> > simply tracks all allocations for basic leak analysis. >> > >> > Abort on allocation failure would be a perfectly reasonable = behavior >> > for bsdgrep(1), too. >>=20 >> There are multiple, competing definitions floating around the = internet. I was genuinely curious where this variant came from because I = wanted to make sure we weren=E2=80=99t just zapping a file that some = upstream uses somewhere, in the event we were going to bring down = further updates, again, from said upstream source. >>=20 >> FWIW- I did scour the internet for other bsdgrep implementations and = did not find a trace of this in any of the others that I found, to = include the OS X implementation. In fact, as I recall, most of them = didn't even have the regex/ bits that we do, presumably they were using = regex(3) but it's been a while since I was poking around. >=20 > Well, for the history of bsdgrep, you have to go back to freegrep: >=20 > https://jameshoward.us/software/freegrep/ >=20 > but the most significant changes are likely to be due to Gabor: >=20 > https://wiki.freebsd.org/BSDgrep So=E2=80=A6. Gabor added xmalloc then ;p=E2=80=A6 -Ngie --Apple-Mail=_7A898D46-24EB-4B69-BEA2-EF8E4CCD0680 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJY5FTGAAoJEPWDqSZpMIYVzJoP/2J2GJ0GWcC9fTkOHdMUe08w fAUVSiRL/dn8OKbHrdITlzPY3aoglXLRLETmNn80YYxxrLI3OpjQhxItHpM4Hmib u1nAp46Bo9W4pt68I+J5ITsrApEr7K/XE5D6Cg2IbWzVd4/seBM4k/qOn6aP2tA7 4W2zn1O2Wprsm4+MZEtsu9pr5o256vqDhBkzLJWIBtDIePEVSHypS/ZyuxDefrTX /K5rCedjHxZOpGdNBc4LbaSgu0kEZs+yChGwE9pqtIltCEfv1el1QbKljQw70WE1 bccJ1fYOKYWMfyoDlPzZ0NWZq6adL/hM+GVR6SBTM4avU/i8oCcZJ7tNgM8WhFzM AB69pTXfRj95OCEgG8I+d3ZDXeE3h2DYe2L9Uj0zqL4v/8O+nxsVpZJN1Rx3ZGBs 2NPksq7VjPm2RsSidbRFWCy1p7qhymgaiiw5g+10ilFQzHUpm0o4Gz+FjFxMTeiq g4N9lr3IeEPt8Rz0XfFQTRIKF6PbK0PaiZURLCExkZ/SIHyb0Mhtrqllu8XJHAyj xDH6kHSNhl0EETdt3/c5SpyxA8W8I1YmodbOnfzkmRpnEpHJ7Fljw/K+zkVNuznh /Wb3sWVTm5cM3mCZpLV8AMN4E4vTT7ZUb0qZrZs8VwLrWNFEK2HNCwOwTPrVMFTS M+SQBYgQsqH3C88dmKx5 =Rwgb -----END PGP SIGNATURE----- --Apple-Mail=_7A898D46-24EB-4B69-BEA2-EF8E4CCD0680--