From owner-freebsd-current  Fri Aug 17  8:45: 3 2001
Delivered-To: freebsd-current@freebsd.org
Received: from dragon.nuxi.com (dsl092-013-169.sfo1.dsl.speakeasy.net [66.92.13.169])
	by hub.freebsd.org (Postfix) with ESMTP
	id B319D37B40B; Fri, 17 Aug 2001 08:44:45 -0700 (PDT)
	(envelope-from obrien@NUXI.com)
Received: (from obrien@localhost)
	by dragon.nuxi.com (8.11.5/8.11.1) id f7HFicI95272;
	Fri, 17 Aug 2001 08:44:38 -0700 (PDT)
	(envelope-from obrien)
Date: Fri, 17 Aug 2001 08:44:38 -0700
From: "David O'Brien" <obrien@FreeBSD.ORG>
To: Bruce Evans <bde@zeta.org.au>
Cc: Ruslan Ermilov <ru@FreeBSD.ORG>, current@FreeBSD.ORG,
	Mark Peek <mark@whistle.com>, Warner Losh <imp@harmony.village.org>
Subject: Re: Cross builds and upgrade path from 4.x are broken in usr.bin/file
Message-ID: <20010817084437.C5916@dragon.nuxi.com>
Reply-To: obrien@FreeBSD.ORG
References: <20010814203045.A60765@sunbay.com> <20010815120844.C17139-100000@besplex.bde.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <20010815120844.C17139-100000@besplex.bde.org>; from bde@zeta.org.au on Wed, Aug 15, 2001 at 12:40:19PM +1000
X-Operating-System: FreeBSD 5.0-CURRENT
Organization: The NUXI BSD group
X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3  90 76 5D 69 58 D9 98 7A
X-Pgp-Rsa-Keyid: 1024/34F9F9D5
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

On Wed, Aug 15, 2001 at 12:40:19PM +1000, Bruce Evans wrote:
> On Tue, 14 Aug 2001, Ruslan Ermilov wrote:
> 
> > On Tue, Aug 14, 2001 at 08:55:56AM -0700, David O'Brien wrote:
> > > >From a correctness stand point, building the .mgc files at install time
> > > is the correct thing to do... or maybe we should do both -- doing the
> > > [re]creation of the .mgc files at install time in the cross-[arch-]build
> > > case.
> 
> Not both.

Which do you prefer?  The CC_HOST way, the build-tools way, or the at
install time way?

> > +build-tools: mkmagic
> > +
> > +mkmagic: apprentice.c print-hacked.c
> > +	${CC} -DHAVE_CONFIG_H -DCOMPILE_ONLY \
> > +	    -I${.CURDIR} -I${SRCDIR} -o ${.TARGET} ${.ALLSRC}
> 
> This should use CFLAGS if possible, and should use LDFLAGS, something
> like:
> 
> 	${CC} -DCOMPILE_ONLY {CFLAGS} ${LDFLAGS} -o ${.TARGET} ${.ALLSRC}

The include path in CFLAGS is wrong for this:

    -I/FBSD/5.x/usr.bin/file -I/FBSD/5.x/usr.bin/file/../../contrib/file
    -I/usr/obj/FBSD/5.x/i386/usr/include

namely pointing into /usr/obj.

-- 
-- David  (obrien@FreeBSD.org)

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message