Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 11 May 1997 19:23:46 +1000
From:      Bruce Evans <bde@zeta.org.au>
To:        cvs-all@FreeBSD.ORG, CVS-committers@FreeBSD.ORG, cvs-lib@FreeBSD.ORG, davidn@FreeBSD.ORG
Subject:   Re: cvs commit:  src/lib/libutil login_tty.3 logout.3 logwtmp.3 setproctitle.3 uucplock.3
Message-ID:  <199705110923.TAA23475@godzilla.zeta.org.au>

next in thread | raw e-mail | index | archive | help
>  Branch:      lib/libutil  RELENG_2_2
>  Modified:    lib/libutil  login_tty.3 logout.3 logwtmp.3 setproctitle.3
>                        uucplock.3
>  Log:
>  MFC: #include <sys/types.h> in synopsis.

Documented intefaces shouldn't be changed.  It was particularly bad to
break application interfaces to support an internal library function.
I fixed it like this:

---
diff -c2 libutil.h~ libutil.h
*** libutil.h~	Sun May 11 10:29:11 1997
--- libutil.h	Sun May 11 14:24:52 1997
***************
*** 42,49 ****
  int	forkpty __P((int *amaster, char *name,
  		     struct termios *termp, struct winsize *winp));
  char	*uu_lockerr __P((int uu_lockresult));
  int	uu_lock __P((char *ttyname));
  int	uu_unlock __P((char *ttyname));
- int	_secure_path __P((const char *path, uid_t uid, gid_t gid));
  __END_DECLS
  
--- 42,51 ----
  int	forkpty __P((int *amaster, char *name,
  		     struct termios *termp, struct winsize *winp));
+ #ifdef _SYS_TYPES_H_
+ int	_secure_path __P((const char *path, uid_t uid, gid_t gid));
+ #endif
  char	*uu_lockerr __P((int uu_lockresult));
  int	uu_lock __P((char *ttyname));
  int	uu_unlock __P((char *ttyname));
  __END_DECLS
--- 

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199705110923.TAA23475>