From owner-cvs-lib Sun May 11 02:26:13 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id CAA20089 for cvs-lib-outgoing; Sun, 11 May 1997 02:26:13 -0700 (PDT) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id CAA20082; Sun, 11 May 1997 02:26:01 -0700 (PDT) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.5/8.6.9) id TAA23475; Sun, 11 May 1997 19:23:46 +1000 Date: Sun, 11 May 1997 19:23:46 +1000 From: Bruce Evans Message-Id: <199705110923.TAA23475@godzilla.zeta.org.au> To: cvs-all@FreeBSD.ORG, CVS-committers@FreeBSD.ORG, cvs-lib@FreeBSD.ORG, davidn@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libutil login_tty.3 logout.3 logwtmp.3 setproctitle.3 uucplock.3 Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > Branch: lib/libutil RELENG_2_2 > Modified: lib/libutil login_tty.3 logout.3 logwtmp.3 setproctitle.3 > uucplock.3 > Log: > MFC: #include in synopsis. Documented intefaces shouldn't be changed. It was particularly bad to break application interfaces to support an internal library function. I fixed it like this: --- diff -c2 libutil.h~ libutil.h *** libutil.h~ Sun May 11 10:29:11 1997 --- libutil.h Sun May 11 14:24:52 1997 *************** *** 42,49 **** int forkpty __P((int *amaster, char *name, struct termios *termp, struct winsize *winp)); char *uu_lockerr __P((int uu_lockresult)); int uu_lock __P((char *ttyname)); int uu_unlock __P((char *ttyname)); - int _secure_path __P((const char *path, uid_t uid, gid_t gid)); __END_DECLS --- 42,51 ---- int forkpty __P((int *amaster, char *name, struct termios *termp, struct winsize *winp)); + #ifdef _SYS_TYPES_H_ + int _secure_path __P((const char *path, uid_t uid, gid_t gid)); + #endif char *uu_lockerr __P((int uu_lockresult)); int uu_lock __P((char *ttyname)); int uu_unlock __P((char *ttyname)); __END_DECLS --- Bruce