Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 17 Jun 2012 13:03:51 +0000 (UTC)
From:      Davide Italiano <davide@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r237195 - head/sys/kern
Message-ID:  <201206171303.q5HD3pl9009185@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: davide
Date: Sun Jun 17 13:03:50 2012
New Revision: 237195
URL: http://svn.freebsd.org/changeset/base/237195

Log:
  The variable 'error' in sys_poll() is initialized in declaration to value
  zero but in any case is overwritten by successive copyin(), making the
  previous initialization useless. Remove this.
  As an added bonus this fixes a style(9) bug.
  
  Discussed with:		kib
  Approved by:		gnn (mentor)
  MFC after:		3 days

Modified:
  head/sys/kern/sys_generic.c

Modified: head/sys/kern/sys_generic.c
==============================================================================
--- head/sys/kern/sys_generic.c	Sun Jun 17 11:36:28 2012	(r237194)
+++ head/sys/kern/sys_generic.c	Sun Jun 17 13:03:50 2012	(r237195)
@@ -1255,7 +1255,7 @@ sys_poll(td, uap)
 	struct pollfd *bits;
 	struct pollfd smallbits[32];
 	struct timeval atv, rtv, ttv;
-	int error = 0, timo;
+	int error, timo;
 	u_int nfds;
 	size_t ni;
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201206171303.q5HD3pl9009185>