From owner-svn-src-head@freebsd.org Tue Feb 13 19:43:26 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9C0FCF1E47F; Tue, 13 Feb 2018 19:43:26 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-it0-x22c.google.com (mail-it0-x22c.google.com [IPv6:2607:f8b0:4001:c0b::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2D5356CDDB; Tue, 13 Feb 2018 19:43:26 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-it0-x22c.google.com with SMTP id n206so12205826itg.1; Tue, 13 Feb 2018 11:43:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=zJcUCHazPIKRq3ZzD5ceQNTIEiNbB8Mn0yib87yXeWg=; b=jwGhLRNO6tkMJol73fenCt1/4B5mdH16NXZrz6nGLVp7Dc3mxyKg0QBzYTWcomKOIv wc9gaANARiArdywh5uYDSPu96jw1zQslbubknWwau9aiUsbkZ9vez8V4wY8xfLmyvjro IBnWmCLK23iT7TjjUhadUzazfROfh/JdiiicWHFB/1ZJnlujA2qjh5YKLMKBQvHWnDcF UVWNXmUnHFFYWKBcrKgOzFyeCb7IwCbvfO7s+xevu3YyYmqJOb+U6o0Tr+3VNssIqxWU hE08JCtnJrE7Oc7vxskLCXDau2htqIseROY7kQeH1uGihuKh9bSjDXRdHEB2OPf7MLsI S+IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=zJcUCHazPIKRq3ZzD5ceQNTIEiNbB8Mn0yib87yXeWg=; b=ifhSgJQGo60OLwn2byWsiVhKYQvmM/6KfETZYuZ/B3jsbSe0j3iut7/DgVcnlhkkFz rjfLbj7CBXbfVIww24v0xuA4Qt1u+TzqVtJrCKZB9U/jTnZe6CuxTXfuxDWae6nmf4ot hoivX8+CjhAr6cF3l2S0rSohImZ1LpUFHrE7oU/c1V9tOzvGDt2eKP9JGse391OvhtNn 8n9RUtanojhqN1dSKj7HXIUBN1Cdtm2UZQJMI3nGIG0UFUa8fYnupYHPuCWDOWnjIp3N b4unREBWrBUphHBCHfBzqFoeoEeU4RJJ9aiyWJWYUoLHFZb8I1nKryKI2Jf5+OHFYYD4 FAqg== X-Gm-Message-State: APf1xPAHkf07JuQXT2H97ykw82xDoaND7sT/TSuU/R6PCpfW1OzcLyTk XT4UbK65XQSsV2ugKP+INPpTEkY/xiUACsrVp/eAog== X-Google-Smtp-Source: AH8x226eBt1I52wPe8okBLiBr3bcxbHtpKAElbJwaQU1JmL0vMwhSS2+3MXujOVbRwv3WF9WF02wQrQ7tFdUA0gp1gI= X-Received: by 10.36.208.4 with SMTP id m4mr1096323itg.69.1518551005370; Tue, 13 Feb 2018 11:43:25 -0800 (PST) MIME-Version: 1.0 Sender: carpeddiem@gmail.com Received: by 10.107.147.9 with HTTP; Tue, 13 Feb 2018 11:43:04 -0800 (PST) In-Reply-To: <1518549829.85310.39.camel@freebsd.org> References: <201802131917.w1DJHmso047463@repo.freebsd.org> <1518549829.85310.39.camel@freebsd.org> From: Ed Maste Date: Tue, 13 Feb 2018 14:43:04 -0500 X-Google-Sender-Auth: pOipul-8t9zivbRfFb8Q2k77IvI Message-ID: Subject: Re: svn commit: r329237 - head/sys/libkern To: Ian Lepore Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Feb 2018 19:43:26 -0000 On 13 February 2018 at 14:23, Ian Lepore wrote: > On Tue, 2018-02-13 at 19:17 +0000, Ed Maste wrote: >> Author: emaste >> Date: Tue Feb 13 19:17:48 2018 >> New Revision: 329237 >> URL: https://svnweb.freebsd.org/changeset/base/329237 >> >> Log: >> libkern: use nul for terminating char rather than 0 >> >> Akin to the change made in r188080 for lib/libc/string/. >> >> Reported by: bde >> Sponsored by: The FreeBSD Foundation > > There are many ways to spell 0. Why are we using something other than > the simplest way? Is it a style rule thing, or is it portability- > correctness, or what? I made the change to improve consistency between lib/libc/string and sys/libkern, which is what Bruce commented on some time ago. I don't have a personal preference for 0 or '\0' but definitely believe that if we have multiple, similar copies of a function they ought to avoid gratuitous differences. (I'm happy to change both trees to 0 if that's preferred.)