From owner-svn-src-all@freebsd.org Tue Nov 21 02:38:35 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6AE18DC183F; Tue, 21 Nov 2017 02:38:35 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lf0-x235.google.com (mail-lf0-x235.google.com [IPv6:2a00:1450:4010:c07::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E0D8D7978B; Tue, 21 Nov 2017 02:38:34 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lf0-x235.google.com with SMTP id m1so12334957lfj.9; Mon, 20 Nov 2017 18:38:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=9tuPzII056eb3D11Y+bjg9bFWR620WNYwxcbTny9CCk=; b=BoJlyssY8nLVdLaUPGTB8fTdsbRkJv/40GOctNghL2sP1wN5vEiNffuMyFONpHdiPS ImT7bBNBbNHZPuXDEfSNA5Y1mI7xslmLaxvTxc/86djiEI9ULa+1FNjJOZsKvW6PrWo/ dO2Zv2MPH7nj9u/K7gIRgIiINKNua09/thJLxPMcmzHV29BmhJJ3XAeqA9JS/SwDQiug Se6U1pY7R4IErHmF+Jnyn2FMBEZQEuXvW/YkL6Qdzj0x1eX8ltTKVfDTviWHYGArTbco tJPSM/p4ZpsoyFx1K10AFZ953wyGQRqxIdcId1TFymkLm6rP41mQNhBWPBxrBownn0a0 ABJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=9tuPzII056eb3D11Y+bjg9bFWR620WNYwxcbTny9CCk=; b=Jt6biotzglXHHyTmVymK/5tCw/pzHgGhbJ6aVW3DOk7dtUBQPYj3LkKXZhkQQIu68D jtknmV6Yd6u5dQznC5ZgMs8fFzxNfHeOcPA+uaSv34qUM9waxq2UzdP8iuU7zW6TDvwv AvVPW5MFnebwAL/I/YOlXMimyF1uYOGKdY4WwlRsuCQtJLNV+vzvT259Lq00DIhbgee5 5SBnWlp/rZnZYewL7OXl6Lf6rAU1VUDhoVRWKVE+yutKjIhLAFpQazL3RN2F5vmwVzwt kmnIztmmXvbt3zyKB8Mv25w0FMMhCJJ1pFEjon3IIxeGzqvusLUB1lKNsKnhpRfIfvSM pQSA== X-Gm-Message-State: AJaThX6iamKX1b0QJVd1Ttvmh0AZgnmdTrptowifJqmC4a+CZR1ov9B7 YhNnYbkhTZpy8/XDBVzOpOQhuN0qFtrt4dFBX7E= X-Google-Smtp-Source: AGs4zMaFKHn5rcIkohVkDSopn/O8pkhnFDrmQwpsOGV3wVxFFFCzz2hP59oHUy9CuT45NX7nkQiiHvLnJhEDXR5L7A4= X-Received: by 10.25.216.88 with SMTP id p85mr4938136lfg.21.1511231911953; Mon, 20 Nov 2017 18:38:31 -0800 (PST) MIME-Version: 1.0 Sender: asomers@gmail.com Received: by 10.179.76.19 with HTTP; Mon, 20 Nov 2017 18:38:31 -0800 (PST) In-Reply-To: References: <201711202255.vAKMt2nP014201@repo.freebsd.org> From: Alan Somers Date: Mon, 20 Nov 2017 19:38:31 -0700 X-Google-Sender-Auth: fuu5daOZ4WdNIGBzVcHgb5MiV5c Message-ID: Subject: Re: svn commit: r326039 - in head: etc/mtree usr.bin/head usr.bin/head/tests To: Benjamin Kaduk Cc: Ed Maste , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , src-committers Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 02:38:35 -0000 On Mon, Nov 20, 2017 at 6:48 PM, Benjamin Kaduk wrote: > On Mon, Nov 20, 2017 at 7:36 PM, Alan Somers wrote: >> >> >> Are there any automated tools that care about the "Differential >> Revision" field? If so, they should be able to tell the difference >> between GitHub revisions and Phabricator revisions based on the URL. > > > > Yes, Phabricator itself uses the link to close out the review. > > >> >> Using "Differential Revision" instead of "Pull request" is handy, >> because it's part of the standard commit template, which encourages >> consistency. > > > As Warner says, we could just add a new thing to the template instead > of overloading an existing one for convenience. > > -Ben Okeedookee. Here you go: https://reviews.freebsd.org/D13179 https://reviews.freebsd.org/D13178 -Alan