Date: Mon, 24 Sep 2018 11:46:05 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r479028 - head/games/yadex Message-ID: <20180924094605.yp7glametgllfqi4@ogg.in.absolight.net> In-Reply-To: <20180917153634.GA60182@FreeBSD.org> References: <201809051631.w85GVdwR029041@repo.freebsd.org> <20180905214947.3msj2lkffek66vbo@atuin.in.mat.cc> <20180906133003.GA14967@FreeBSD.org> <20180917153634.GA60182@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--tck2soy4e754dafe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 17, 2018 at 03:36:34PM +0000, Alexey Dokuchaev wrote: > On Thu, Sep 06, 2018 at 01:30:03PM +0000, Alexey Dokuchaev wrote: > > On Wed, Sep 05, 2018 at 11:49:47PM +0200, Mathieu Arnold wrote: > > > On Wed, Sep 05, 2018 at 04:31:39PM +0000, Alexey Dokuchaev wrote: > > > > New Revision: 479028 > > > > URL: https://svnweb.freebsd.org/changeset/ports/479028 > > > >=20 > > > > Log: > > > > Consummate conversion to option helpers (should've been part of > > > > r479022). > > > >=20 > > > > Modified: head/games/yadex/Makefile > > > > @@ -37,17 +37,10 @@ PATCH_SUFFIX=3D .diff > > > > PATCHFILES=3D ${PATCH_PREFIX}_Depend${PATCH_SUFFIX} > > > > =20 > > > > 3D_RENDER_PATCHFILES=3D ${PATCH_PREFIX}_Render3D${PATCH_SUFFIX} > > > > +3D_RENDER_PORTDOCS=3D preview.html > > >=20 > > > This is missing a 3D_RENDER_IMPLIES=3DDOCS. > >=20 > > I don't think so, why? One of the nice things about PORTDOCS that is c= an > > (and should) be set unconditionally (independent of DOCS). In fact, I > > could have simply got away with PORTDOCS=3D* but I prefer to avoid glob= bing. > >=20 > > If you build the package with OPTIONS_UNSET=3DDOCS and OPTIONS_DEFAULT= =3D > > 3D_RENDER you'll see that the package is generated correctly (without t= he > > docfiles). >=20 > I see you've jumped over and added this in r479406. This is not how we > do things in FreeBSD. Either back it out or reply to my reasoning above > with proper explanation of where and why I'm wrong. Mmmm, you are right, this one was not required, it fell through the cracks of all the DOXYGEN and related options that do require DOCS. --=20 Mathieu Arnold --tck2soy4e754dafe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAluosl1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkhT4Q/9FDqBMmW3rzI8BY6s45MWKprYBoKjnm/iFt9kechm4D+uvFs+D0bXYPpS kpPY541mwW13buL8Iq0EUs6719A/OI/2HTqMmRSIvn81JSC+J7Ft6gNnPbNEplt6 zentUMsvq/BzJbjeHHnZOW3G7c5DSZcsIy8paSHDhmDZOpSjLYdblLgZVzCvwnCs xgzsW1rphcbonrCh4+38P/gTAquSaXVAVZWPx5LAAu559woyiGfQ4rkXeyVrboFq DdaiVaTJR3/dh8M3aexhRTzyxOki2ncDoys37EwaLhktHbkrsuZiv2Il4zswSfMp zU6S9xdIrWeuZZ6BcDyAGdZ4bBcgB12GruKRKmp1RunYGlzEN932gvZJEwSM7mjw Jq5xfaJOAGGquhKF7rz0lIeM+NLT08w6s8e9lelAH2DUUG2QY0q39ncq0wqmebBW jmJTGQFWGPDJgDgGwKt57/FyzPAcv0nkUAmqQU66w5/a6Rb1Jt5gqINIy0Y6CPBN 1F8LF8SsyE7kL130B9AjtzO+uDsF0XM3BwISILCbh1Rvc6nzPeHtASkOW5gGKLPI re7C3any2AWXC+SM6sMq30sBtjcgTyGYJ8/pSrbP+yysYDgkgIccoMuqoivWi7Xq 51gjAg+VQr+Ebtj7paV9JKGEQQwpiaf2V/uKGoDR7oPu1ML1wzU= =LySW -----END PGP SIGNATURE----- --tck2soy4e754dafe--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180924094605.yp7glametgllfqi4>