From owner-dev-commits-ports-all@freebsd.org  Tue Aug 24 09:43:50 2021
Return-Path: <owner-dev-commits-ports-all@freebsd.org>
Delivered-To: dev-commits-ports-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id C1EA56545F5;
 Tue, 24 Aug 2021 09:43:50 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4Gv41f4zzxz4l9P;
 Tue, 24 Aug 2021 09:43:50 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim;
 t=1629798230;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 references:references; bh=HkVWII92365aQrCjMZhKV1ZiqP7qOy1ox6tAYOOXGao=;
 b=TbSPsuJ7uKoCPo4Xgxe9qfPfsjbECtC9AdLtPguKhJHIlJp5HKEA1oq4qmkN64gcDoVQeQ
 vQ6ncWbmNe7ykp+v7wKH9S/OeHdlhVWIhG3Rg00Ccw9qo6LBYwKGN85Fj5ayBBrtadO7Pp
 UAUsv3rh+A/wK0ozWVJn11Lo7U6QDBnJKOalvZHvjdSWzLPRblD1fL3WJiWoIiv65RgmRC
 LRTKw9p9W7hmNmkiLYj+FvgIEJfwCtHSmbDuJNq6voRJ7oShH5bNZ0WlltMRVPXtRQtCVK
 N2N4LKj9Gd+MMVYkWRQDrTfFan6jDZm4OmoxvJUvlTR8vrbvz60MhKuefqBqgg==
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id 8429D4C97; Tue, 24 Aug 2021 09:43:50 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: ports-committers@FreeBSD.org
Cc: dev-commits-ports-all@FreeBSD.org,
	dev-commits-ports-main@FreeBSD.org
Subject: Re: git: 12b0f2edf6a5 - main - security/authenticator: unbreak with
 libadwaita >= 2021-05-20 snapshot
References: <202108240859.17O8xi7R059389__9761.96919088892$1629795601$gmane$org@gitrepo.freebsd.org>
Date: Tue, 24 Aug 2021 11:43:47 +0200
Message-ID: <k0kb-uqi4-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org;
 s=dkim; t=1629798230;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 references:references; bh=HkVWII92365aQrCjMZhKV1ZiqP7qOy1ox6tAYOOXGao=;
 b=F9AHSWmmctuZ8EQkoPcoS/yVl9HnxoPfB+p9ahy8Nivo6gQ9LSG+4nVCMCxjw/0KC1BxTe
 5NNO/nwCIayVAdSGsjbih7ek7BltGngj86gKN7AvLVIQZL4pgE9fZuYvQubBnGZ9lPSR1Q
 BtuwWObYI7MCnFAY4dL0Qo2B54hIXHdECER9WIK1JR/3CtGhpsyzmkJonhpj+8JmvjTSmu
 fN/NzbqgD71Pcx8fuOzdiqTTWNiVDPt1y5D/LmvtFNNLVhAusVZPtJpa641ECGTumC+0QQ
 iOSZev1POO0Tx7tLCmIL/91blEDNNscThn59X82/Uxk342N5cpg7TYtJ3SRDzg==
ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1629798230; a=rsa-sha256; cv=none;
 b=jNcF8GGe1u9jhEd/BIAEri8W26x4IZX1rTIt0+P3t/51wtAUuv3ndV5OoObEjouhY62A7N
 QWwtljLk/d/HAggaNIh1NXFYGIKIfqFGwyck3mQTHGjCc5MnvmBJEkDZtbIsvYTbX0N+6B
 Cdfl6PB2Du7IlCp2EUNv9RyRgeUAB7P0YO4r9gbUbDMY+wjOq9GjM5HwjN/DXx/3Loc8jX
 3stVoX66az9Lw28A4Wa78fbiD+Gy3KCTZ0DZSfTNlxi3MiSrEwNRCS+n+l+x0YnN5tXyud
 8YlbIrKfQ6MYg4gy4hCHDuqFppkotTpbUxvXz3YYLlIWOUN1ZIeta18GnhYBlA==
ARC-Authentication-Results: i=1;
	mx1.freebsd.org;
	none
X-BeenThere: dev-commits-ports-all@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for all branches of the ports repository
 <dev-commits-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-ports-all>, 
 <mailto:dev-commits-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-ports-all/>
List-Post: <mailto:dev-commits-ports-all@freebsd.org>
List-Help: <mailto:dev-commits-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-ports-all>, 
 <mailto:dev-commits-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Aug 2021 09:43:50 -0000

Jan Beich <jbeich@FreeBSD.org> writes:

> The branch main has been updated by jbeich:
>
> URL: https://cgit.FreeBSD.org/ports/commit/?id=12b0f2edf6a5e4548fba1e55d7e64b78fbdb894e
>
> commit 12b0f2edf6a5e4548fba1e55d7e64b78fbdb894e
> Author:     Jan Beich <jbeich@FreeBSD.org>
> AuthorDate: 2021-08-24 08:51:36 +0000
> Commit:     Jan Beich <jbeich@FreeBSD.org>
> CommitDate: 2021-08-24 08:56:17 +0000
>
>     security/authenticator: unbreak with libadwaita >= 2021-05-20 snapshot
>     
>     $ authenticator
>     (<unknown>:1234): GLib-GObject-WARNING **: specified class size for type 'UrlRow' is smaller than the parent type's 'AdwActionRow' class size
>     (<unknown>:1234): GLib-GObject-WARNING **: cannot add private field to invalid (non-instantiatable) type '<invalid>'
>     thread 'main' panicked at 'assertion failed: type_.is_valid()', src/widgets/url_row.rs:17:5
>     note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Upstream only supports Flatpak, so it took a while to find working
libadwaita (C library) revision.

https://gitlab.gnome.org/World/Authenticator/-/blob/4.0.3/build-aux/com.belmoussaoui.Authenticator.Devel.json
https://gitlab.gnome.org/World/Authenticator/-/blob/4.0.3/Cargo.lock
https://gitlab.gnome.org/World/Rust/libadwaita-rs/-/tree/6ae4d3670565/subprojects/libadwaita.wrap

Packaging this was already non-trivial due to CARGO_GIT_SUBDIR mess and
zbus backport complications. I can't test further due to lack of a camera:

$ authenticator
<click on "+" button>
(<unknown>:70623): Gdk-WARNING **: Compositor doesn't support moving popups, relying on remapping
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: BoolError { message: "Failed to start", filename: "../gstreamer-rs-762450b/gstreamer/src/auto/device_monitor.rs", function: "gstreamer::auto::device_monitor", line: 106 }', src/widgets/camera.rs:191:31
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

$ cat .../device_monitor.rs
    fn start(&self) -> Result<(), glib::error::BoolError> {
        unsafe {
            glib::result_from_gboolean!(
                ffi::gst_device_monitor_start(self.as_ref().to_glib_none().0),
                "Failed to start"
            )
        }
    }

$ cat .../camera.rs
    fn init_monitor(&self) {
        let self_ = imp::Camera::from_instance(self);
        let caps = gst::Caps::new_simple("video/x-raw", &[]);
        self_.monitor.add_filter(Some("Video/Source"), Some(&caps));

        self_.monitor.start().unwrap();


$ GST_DEBUG=2 gst-device-monitor-1.0 Video/Source:video/x-raw
Probing devices...

0:00:00.004344341 70618    0x8013c2f80 WARN                 default gstdevicemonitor.c:466:gboolean gst_device_monitor_start(GstDeviceMonitor *):<devicemonitor0> No providers match the current filters
Failed to start device monitor!
<exit code 255>