From owner-freebsd-hackers@FreeBSD.ORG Tue Jul 26 07:16:34 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 60477106564A for ; Tue, 26 Jul 2011 07:16:34 +0000 (UTC) (envelope-from etnapierala@googlemail.com) Received: from mail-ey0-f176.google.com (mail-ey0-f176.google.com [209.85.215.176]) by mx1.freebsd.org (Postfix) with ESMTP id E12B68FC0A for ; Tue, 26 Jul 2011 07:16:33 +0000 (UTC) Received: by eya28 with SMTP id 28so243042eya.21 for ; Tue, 26 Jul 2011 00:16:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=sender:subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer; bh=yQniMGF+bFXuet75Y+K2jUDM7ouCzpSOZF8W952hwok=; b=BiOijBp86lAcTepvTDfsRTtX85j8E08xXSF+5EtlLz4lIA4vjhwvcxyc9iYARzMFii N+NsZ3kGB4cSkNUiUO4l/jSMtM4NZES/IHWaXlapBDAu2+SvqZfuoDJhnGcYfn6QRPya a8lMtX914JxJ2bZJF/gYHQAXPSvajNjvVOzvE= Received: by 10.213.22.18 with SMTP id l18mr641484ebb.119.1311664592423; Tue, 26 Jul 2011 00:16:32 -0700 (PDT) Received: from enapierala.whl (58.wheelsystems.com [83.12.187.58]) by mx.google.com with ESMTPS id p49sm135740eef.24.2011.07.26.00.16.30 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 26 Jul 2011 00:16:31 -0700 (PDT) Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= Mime-Version: 1.0 (Apple Message framework v1244.3) Content-Type: text/plain; charset=iso-8859-2 From: =?iso-8859-2?Q?Edward_Tomasz_Napiera=B3a?= In-Reply-To: <20110724230617.GA69612@freebsd.org> Date: Tue, 26 Jul 2011 09:16:28 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <8D7CEA8F-AF55-4509-9C90-74FC42A9A020@freebsd.org> References: <0CEA161B-6767-4379-B923-585B3D4EA74E@freebsd.org> <86hb6e1bau.fsf@gmail.com> <589EB85A-1902-4643-A1FD-3C98445127DB@freebsd.org> <20110724222224.GA64487@freebsd.org> <20110724230617.GA69612@freebsd.org> To: Alexander Best X-Mailer: Apple Mail (2.1244.3) Cc: Test Rat , freebsd-hackers@freebsd.org Subject: Re: Autosizing column widths in ps(1). X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jul 2011 07:16:34 -0000 Wiadomo=B6=E6 napisana przez Alexander Best w dniu 25 lip 2011, o godz. = 01:06: > On Sun Jul 24 11, Alexander Best wrote: >> On Sun Jul 24 11, Edward Tomasz Napiera?a wrote: >>> Wiadomo?? napisana przez Test Rat w dniu 22 lip 2011, o godz. 19:21: >>>> Edward Tomasz Napiera?a writes: >>>>=20 >>>>> Patch below changes ps(1) to automatically size column widths = according to their >>>>> contents. =46rom the user point of view, it prevents breaking = layout with too wide values >>>>> and in most cases makes output narrower. =46rom the developer = point of view, it removes >>>>> the need to specify widths. Testing is welcome - the patch = shouldn't change ps(1) >>>>> behaviour except slightly changing the widths, but the code = changes are pretty large >>>>> and it's quite possible I've missed something. >>>>=20 >>>> STAT column seems to be right-aligned when it was previously = left-aligned. >>>> This makes sorting it harder, e.g. >>>>=20 >>>> $ ps ax | (IFS=3D; read h; echo $h; sort -k3) | less >>>=20 >>> Good catch, thanks! Updated patch, which also fixes two issues = affecting TTY column, >>> is at http://people.freebsd.org/~trasz/ps-9.diff. >=20 > any reason there are always a minimum of 2 spaces between the "TT" and = the > "TIME" column and not a single space? The 'TT' column ends with either a space, or a '-'. As you've noticed, = in the common case there will be no hyphens there; I'll see if I can remove the extra = spacing. -- If you cut off my head, what would I say? Me and my head, or me and my = body?