From owner-freebsd-fs@FreeBSD.ORG Wed Nov 2 06:38:11 2011 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DA9AE1065673 for ; Wed, 2 Nov 2011 06:38:11 +0000 (UTC) (envelope-from jdc@koitsu.dyndns.org) Received: from QMTA11.westchester.pa.mail.comcast.net (qmta11.westchester.pa.mail.comcast.net [76.96.59.211]) by mx1.freebsd.org (Postfix) with ESMTP id 8506F8FC1A for ; Wed, 2 Nov 2011 06:38:11 +0000 (UTC) Received: from omta23.westchester.pa.mail.comcast.net ([76.96.62.74]) by QMTA11.westchester.pa.mail.comcast.net with comcast id s6eB1h0011c6gX85B6eBRY; Wed, 02 Nov 2011 06:38:11 +0000 Received: from koitsu.dyndns.org ([67.180.84.87]) by omta23.westchester.pa.mail.comcast.net with comcast id s6eA1h00E1t3BNj3j6eBNf; Wed, 02 Nov 2011 06:38:11 +0000 Received: by icarus.home.lan (Postfix, from userid 1000) id 32B0D102C19; Tue, 1 Nov 2011 23:38:09 -0700 (PDT) Date: Tue, 1 Nov 2011 23:38:09 -0700 From: Jeremy Chadwick To: Shivaram Upadhyayula Message-ID: <20111102063809.GA50463@icarus.home.lan> References: <20111101211710.GA36797@voi.aagh.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-fs@freebsd.org Subject: Re: ZFS/compression/performance X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Nov 2011 06:38:11 -0000 On Wed, Nov 02, 2011 at 11:37:49AM +0530, Shivaram Upadhyayula wrote: > Sorry i didn't know it will be stripped out :-) > http://www.quadstor.com/ietbsd/compression.tgz LZF diff is against > FreeBSD8-STABLE checkout about a week ago. Are you sure about that? $ egrep '^---' lzffinal.diff --- cddl/boot/zfs/zfsimpl.h 2011-10-26 14:50:35.000000000 +0530 --- cddl/boot/zfs/zfssubr.c 2011-10-26 14:50:35.000000000 +0530 --- cddl/contrib/opensolaris/common/zfs/zfs_prop.c 2011-10-26 14:50:36.000000000 +0530 --- cddl/contrib/opensolaris/uts/common/Makefile.files 2011-10-27 14:21:41.000000000 +0530 --- cddl/contrib/opensolaris/uts/common/fs/zfs/lzf.c 1970-01-01 05:30:00.000000000 +0530 --- cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zio.h 2011-10-26 14:50:36.000000000 +0530 --- cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zio_compress.h 2011-10-26 14:50:36.000000000 +0530 --- cddl/contrib/opensolaris/uts/common/fs/zfs/zio_compress.c 2011-10-26 14:50:37.000000000 +0530 These pathnames don't reflect reality on FreeBSD RELENG_8. There are no such path names, both on our RELENG_8 systems, nor in CVS: $ ls -l /usr/src/cddl/boot ls: /usr/src/cddl/boot: No such file or directory $ ls -l /usr/src/cddl/contrib/opensolaris/uts ls: /usr/src/cddl/contrib/opensolaris/uts: No such file or directory $ ls -l /usr/src/cddl/contrib/opensolaris total 30 -rw-r--r-- 1 root wheel 18924 Mar 28 2008 OPENSOLARIS.LICENSE drwxr-xr-x 16 root wheel 512 Jun 23 00:43 cmd/ drwxr-xr-x 4 root wheel 512 Jun 23 00:43 common/ drwxr-xr-x 2 root wheel 512 Jun 23 00:43 head/ drwxr-xr-x 10 root wheel 512 Jun 23 00:43 lib/ drwxr-xr-x 3 root wheel 512 Jun 23 00:43 tools/ In CVS there used to be a src/cddl/contrib/opensolaris/uts/common directory but everything in it now is under Attic/, which means it's been deprecated. See for yourself: http://www.freebsd.org/cgi/cvsweb.cgi/src/cddl/contrib/opensolaris/uts/common/ Please advise. -- | Jeremy Chadwick jdc at parodius.com | | Parodius Networking http://www.parodius.com/ | | UNIX Systems Administrator Mountain View, CA, US | | Making life hard for others since 1977. PGP 4BD6C0CB |